Fix detection of util.inspect version#395
Merged
Merged
Conversation
Improve the detection to work in browser too. This fixes a regression introduced in e4fc387.
bajtos
referenced
this pull request
Jan 15, 2015
Return the raw object data when running on Node v0.11.14+ That way all `inspect` options are always preserved. When running on older version: - Honour the depth argument passed to the custom `inspect` function. - Disable color output, becase there is now way how to detect whether colors were enabled or disabled by the top-level caller.
bajtos
added a commit
that referenced
this pull request
Jan 15, 2015
…-version Fix detection of `util.inspect` version
Member
Author
|
Released as |
Contributor
|
Awesome 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the detection to work in browser too. This fixes a regression
introduced in e4fc387 (#389)
/cc @rmg @raymondfeng I'll merge without review to push the fix to npmjs ASAP.