Skip to content

Add documentation about options.http.path in model definition > relations - #556

Merged
bajtos merged 1 commit into
loopbackio:gh-pagesfrom
fgarit:patch-1
Dec 14, 2017
Merged

Add documentation about options.http.path in model definition > relations#556
bajtos merged 1 commit into
loopbackio:gh-pagesfrom
fgarit:patch-1

Conversation

@fgarit

@fgarit fgarit commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

I was looking for a solution to alter the default path of a relation and I stumbled apon this solution which I believe was not documented.

I was looking for a solution to alter the default path of a relation and I stumbled apon this solution which I believe was not documented.
@fgarit
fgarit requested a review from bschrammIBM as a code owner December 1, 2017 08:24
@slnode

slnode commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@bschrammIBM
bschrammIBM requested a review from dhmlau December 1, 2017 19:53
@bschrammIBM

Copy link
Copy Markdown
Contributor

Thank you for submitting this edit. We are taking a look at it now and will confirm shortly.

@bschrammIBM

Copy link
Copy Markdown
Contributor

Please sign the CLA for loopback here:
https://cla.strongloop.com/agreements/strongloop/loopback.io

@jannyHou jannyHou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @FLO-G is there any related code PR in loopback for your suggested feature?

(horrible....I could not change it to a comment or request change....sorry for the duplicate message)

@jannyHou jannyHou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @FLO-G is there any related code PR in loopback for your suggested feature?

@fgarit

fgarit commented Dec 5, 2017

Copy link
Copy Markdown
Contributor Author

Hi @jannyHou I can look for such a PR but I was just basing this on my experience working with the framework.

Here's my configuration:
"loopback": "^3.0.0",
"loopback-boot": "^2.6.5",

Edit: to be honest, it feels like it would take a really deep dive into the code to find the related pull request and I am not sure when I can find the time to do this.

@bajtos

bajtos commented Dec 12, 2017

Copy link
Copy Markdown
Member

@jannyHou this feature has been supported for ages. I think I actually added it myself here: strongloop/strong-remoting#37, see also loopbackio/loopback-datasource-juggler@dbb7c6d

@bajtos

bajtos commented Dec 12, 2017

Copy link
Copy Markdown
Member

Actually, my comment applies to options.http.path for top-level models. This documentation change is for relation options. Here is the line which handles that relation option: lib/model.js#L537. This feature was added by strongloop/loopback#427 AFAICT.

@bajtos bajtos self-assigned this Dec 12, 2017

@jannyHou jannyHou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thank you! LGTM, just please fix the commit message to pass the lint:

**************************************************
**
**  Linting commit logs
**
**  1 problems found:
**    6ed1892 - Add information about options.http.path: line 3 longer than 72 characters.
**
**************************************************

@bschrammIBM bschrammIBM left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after commit message is fixed

@bajtos
bajtos merged commit 52fa0bc into loopbackio:gh-pages Dec 14, 2017
@bajtos

bajtos commented Dec 14, 2017

Copy link
Copy Markdown
Member

I fixed the commit message while running "squash and merge".

Thank you @FLO-G for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants