Improve remoting metadata - Add ctor.http to SharedClass - #37
Merged
Conversation
The SharedClass has the `http` property always set now. If the ctor does not provide `http.path`, a default value of `'/' + name` is used. This way we can decouple the REST (HTTP) routing from the model name and make the REST path accessible from any external code. The second part of the commit modifies ext/swagger to use this new property.
|
Test PASSed. To trigger a build add comment - ".test\W+please" |
Member
|
LGTM |
bajtos
added a commit
that referenced
this pull request
Jan 21, 2014
Improve remoting metadata - Add ctor.http to SharedClass
bajtos
referenced
this pull request
in loopbackio/loopback-datasource-juggler
Jan 21, 2014
Set the HTTP route to `'/' + pluralModelName` so that we don't have to duplicate this bit of logic in strong-remoting and other places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SharedClass has the
httpproperty always set now. If thector does not provide
http.path, a default value of'/' + nameisused. This way we can decouple the REST (HTTP) routing from the model
name and make the REST path accessible from any external code.
The second part of the commit modifies ext/swagger to use this new
property.
/to: @ritch please review
/cc: @raymondfeng @Schoonology
This is the first pull requests in the upcoming series of changes that will make it super easy to generate client code from metadata provided by
RemoteObjectsviaclasses().