This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[android] Reorganize dependencies#10268
Merged
Merged
Conversation
Member
|
@zugaldia lint is complaining about incompatible gradle version for the SDK. This is because the lost dependency and telem are bringing in a couple of support libs. I optimised the dependencies to not include redundant dependencies. eg. fragment + support annoation code is pulled in with supportv7. |
Member
Author
|
Thanks @tobrun for the pass. Lint is still complaining, I need to figure out what the actual error is: |
Member
we need to look into excluding modules from dependencies that rely on 25.1.0 |
Member
Author
tobrun
approved these changes
Oct 26, 2017
20 tasks
tobrun
pushed a commit
that referenced
this pull request
Nov 7, 2017
Closed
This was referenced Nov 14, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR moves some dependencies out of the SDK that are only necessary for the Test App.