This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Look more widely for IBDesignablesAgent#12140
Merged
Merged
Conversation
The IBDesignablesAgent helper process has been renamed for each platform as of Xcode 10, so cast a wider net when trying to detect it.
friedbunny
approved these changes
Jun 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cast a wider net when trying to detect the helper process that builds the Interface Builder designable when MGLMapView is displayed in a storyboard or XIB. Detecting the helper process is important because it keeps mbgl and the telemetry subsystem from initializing and causing the designable to time out or raise an exception. In Xcode 10, the helper process has been renamed on each platform:
(tvOS is mentioned here because of #9319.)
I left out the iOS changelog blurb because this fix by itself doesn’t address #10072 or #10573.
/cc @friedbunny @fabian-guerra