Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Look even more widely for IB designables agent#12883

Merged
1ec5 merged 1 commit into
masterfrom
1ec5-designable-xcode-10-gm
Sep 13, 2018
Merged

Look even more widely for IB designables agent#12883
1ec5 merged 1 commit into
masterfrom
1ec5-designable-xcode-10-gm

Conversation

@1ec5
Copy link
Copy Markdown
Contributor

@1ec5 1ec5 commented Sep 13, 2018

Cast an even wider net than #12140 when trying to detect the helper process that builds the Interface Builder designable when MGLMapView is displayed in a storyboard or XIB. Detecting the helper process is important because it keeps mbgl and the telemetry subsystem from initializing and causing the designable to time out or raise an exception. The helper process has once again been renamed on each platform, according to the Xcode 10 GM seed release notes:

Some binaries used by Interface Builder have been renamed for better consistency. Instead of
“Interface Builder Cocoa Touch Tool”, “Interface Builder WatchKit Tool”, and “IBAppleTVTool”, they are now called “IBAgent-[platform]”. (35400833)

Platform SDK Xcode 9 Xcode 10 beta 1 Xcode 10 GM seed
iOS IBDesignablesAgentCocoaTouch IBDesignablesAgent-iOS IBAgent-iOS, IBDesignablesAgent-iOS
macOS IBDesignablesAgent IBDesignablesAgent-macOS IBDesignablesAgent-macOS
tvOS IBDesignablesAgentAppleTV IBDesignablesAgent-tvOS IBAgent-tvOS, IBDesignablesAgent-tvOS

(tvOS is mentioned here because of #9319.)

I left out the iOS changelog blurb because this fix by itself doesn’t address #10072 or #10573.

/cc @fabian-guerra @friedbunny

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS build macOS Mapbox Maps SDK for macOS labels Sep 13, 2018
@1ec5 1ec5 added this to the ios-v4.5.0 milestone Sep 13, 2018
@1ec5 1ec5 self-assigned this Sep 13, 2018
@1ec5 1ec5 requested a review from fabian-guerra September 13, 2018 08:43
The IBDesignablesAgent helper process has been renamed to IBAgent as of the Xcode 10 GM seed, so cast an even wider net when trying to detect it.
@1ec5 1ec5 force-pushed the 1ec5-designable-xcode-10-gm branch from 2d99be2 to 653c168 Compare September 13, 2018 17:35
@1ec5 1ec5 merged commit c63e628 into master Sep 13, 2018
@1ec5 1ec5 deleted the 1ec5-designable-xcode-10-gm branch September 13, 2018 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants