Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[core] clear source when removed from style#8298

Merged
ivovandongen merged 1 commit into
masterfrom
8273-clear-source-onremove
Mar 7, 2017
Merged

[core] clear source when removed from style#8298
ivovandongen merged 1 commit into
masterfrom
8273-clear-source-onremove

Conversation

@ivovandongen
Copy link
Copy Markdown
Contributor

Fixes #8273

@mention-bot
Copy link
Copy Markdown

@ivovandongen, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @incanus and @ansis to be potential reviewers.

@ivovandongen ivovandongen self-assigned this Mar 7, 2017
@ivovandongen ivovandongen added the Core The cross-platform C++ core, aka mbgl label Mar 7, 2017
@ivovandongen ivovandongen added this to the android-v5.0.0 milestone Mar 7, 2017
Copy link
Copy Markdown
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @ivovandongen. Good illustration of why it would be a good idea to separate tiles and buckets from sources as @kkaefer was suggesting the other day.

I suspect that #8289 and #8275 might be caused by the same issue.

@ivovandongen ivovandongen merged commit 0da6d8a into master Mar 7, 2017
@ivovandongen ivovandongen deleted the 8273-clear-source-onremove branch March 7, 2017 02:04
@kkaefer
Copy link
Copy Markdown
Member

kkaefer commented Mar 8, 2017

👍

1ec5 added a commit that referenced this pull request Mar 10, 2017
Mentioned #8298, #8139. Copyedited recent additions.
1ec5 added a commit that referenced this pull request Mar 10, 2017
* [ios, macos] Updated changelogs

Mentioned #8298, #8139. Copyedited recent additions.

* [ios, macos] Reorganized changelogs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Core The cross-platform C++ core, aka mbgl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants