Skip to content

Add source and source properties to StyleManagerProtocol#320

Merged
julianrex merged 3 commits into
mainfrom
jrex/style-manager-pt2
May 5, 2021
Merged

Add source and source properties to StyleManagerProtocol#320
julianrex merged 3 commits into
mainfrom
jrex/style-manager-pt2

Conversation

@julianrex
Copy link
Copy Markdown
Contributor

@julianrex julianrex commented May 5, 2021

Continuation of #317

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog>Refactored Style source and source property management.</changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This is PR 2 of N (see #317):

  • Adds source and source property functions that throw rather than returning a Result type.
  • Removes updateSourceProperty(...), replacing it with setSourceProperty(...)
  • Updates tests and examples accordingly.

@julianrex julianrex added the breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published label May 5, 2021
@julianrex julianrex marked this pull request as ready for review May 5, 2021 18:28
Comment thread Sources/MapboxMaps/Style/Style.swift
Comment thread Sources/MapboxMaps/Style/Style.swift
Copy link
Copy Markdown
Contributor

@neelmistry94 neelmistry94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit about adding docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants