Update InstructionView to consume turn lane data from sub BannerText#1440
Merged
Conversation
Guardiola31337
approved these changes
Oct 23, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Great work here @danesfeder 💪
Other than one minor comment, this looks great to me 🚀
| * If true, update the "then" maneuver and the "then" step text. | ||
| * If false, hide the then layout. | ||
| * | ||
| * @param subText to determine if the then step layout should be shown |
Contributor
There was a problem hiding this comment.
What about adding the new @param or removing the Javadoc completely?
danesfeder
force-pushed
the
dan-instruction
branch
from
3a3c82d to
00a4e37
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final piece to the
InstructionViewBannerInstructionspuzzle. Previously, we were gathering turn lane data from theRouteProgressevery update and waiting to show them based on duration remaining on the step.This PR removes that logic, as the turn lane data is provided via the
sub()BannerText.