InstructionView: not return when showSubLayout has been called. #3137
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3137 +/- ##
=========================================
Coverage 38.67% 38.67%
Complexity 2248 2248
=========================================
Files 542 542
Lines 19735 19735
Branches 1866 1866
=========================================
Hits 7633 7633
Misses 11221 11221
Partials 881 881 |
…urnLanes will be removed after it. In a case that both the two consecutive bannerInstructions have "sub" node. The first "sub" node is to show turnLanes and the second "sub" node is to show the subText. The existing code will show turnLanes for first "sub" node. Then when it shows the second "sub" node as subText, it "return"s immediately. The first "sub" node doesn't have chance to hide itself.
Guardiola31337
approved these changes
Jun 9, 2020
| instructionLoader.loadInstruction(); | ||
| } | ||
| showSubLayout(); | ||
| hideTurnLanes(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref #3133
This PR fixes an issue mentioned in #3133 which is a different issue.
bug,feature,new API(s),SEMVER, etc.)Goal
Improve UI SDK quality.
Implementation
In the original implementation #1440, it added the
returnstatement. @Guardiola31337 , if you know anything about why it's needed please let me know.But from my testing, in the route of your comment #3133 (comment)
In the route there are two consecutive
bannerInstructions, both havesubnode.The first
subnode is for turnLanes. The secondsubnode is to show the subText.The existing implementation will return after it shows the subText. So the
turnLanesdoesn't have chance to hide itself.Screenshots or Gifs
Testing
See above gif.
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PR