ExampleActivity refactor for simplicity/stability#1884
Merged
Conversation
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #1884 +/- ##
============================================
+ Coverage 35.04% 35.07% +0.02%
Complexity 1060 1060
============================================
Files 261 261
Lines 8848 8839 -9
Branches 667 667
============================================
- Hits 3101 3100 -1
+ Misses 5475 5467 -8
Partials 272 272 |
b04c977 to
b2862d2
Compare
29cf72a to
5208638
Compare
danesfeder
reviewed
Apr 16, 2019
Contributor
danesfeder
left a comment
There was a problem hiding this comment.
@devotaaabel first pass here looks good. Will check back when the animation work is good to go as well. Thanks for running with this
e18803e to
5a23931
Compare
5a23931 to
e21cadd
Compare
Contributor
Author
|
@mapbox/navigation-android I removed the intro animations from the scope of this PR and and working on that separately. This is ready for final review |
danesfeder
approved these changes
Apr 22, 2019
Contributor
danesfeder
left a comment
There was a problem hiding this comment.
@devotaaabel just gave this another pass - everything is looking good, just one minor regression where the destination icon is no longer being drawn:
Once we re-add that, we should be good to go here. Going to go ahead and approve regardless. Thanks!
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This addresses multiple issues with the
ExampleActivity:It simplifies the possible states while adding
SEARCHstate. Previously, there wereSHOW_LOCATION,FIND_ROUTE,ROUTE_FOUNDandNAVIGATEstates. Now, there'sSHOW_LOCATION(just showing users location on the map),SHOW_ROUTE(showing a route either from a destination long clicked on the map, or found via search),SEARCH(search view is open), andNAVIGATE. The directions fab is removed because the intermediary step is no longer needed.Fixes some backstack issues, including pulling in the fix from here and also addressing some of the issues listed in Multiple issues with example activity #1874
Retrieved profile and simulate route values from shared preferences as set in settings activity (still have to add
onActivityResult)Also added some extra visibility for the settings fab
I have added any issue links
I have added all related labels (
bug,feature,new API(s),SEMVER, etc.)I have added the appropriate milestone and project boards
Goal
The goal is to make this activity simpler, more useful for testing, and less buggy, while also allowing the ability to try different settings.
Implementation
Disclaimer: I'm still having some crazy issues with the camera. These issues exist on master so I don't believe they have anything to do with my changes.
Screenshots or Gifs
Let me know if there's any screenshots/gifs that would help this PR.
Testing
Tested the different settings, profiles/simulate route, and tested that the profiles were translating into the urls. UI tested the example flow, including the search, to try to catch edge cases.
SNAPSHOTupstream dependencies if needed)Checklist