Skip to content

Fix Navigation Launcher test app Activity incorrect profile regression#1914

Merged
Guardiola31337 merged 1 commit into
masterfrom
pg-profile-testapp-revert
Apr 29, 2019
Merged

Fix Navigation Launcher test app Activity incorrect profile regression#1914
Guardiola31337 merged 1 commit into
masterfrom
pg-profile-testapp-revert

Conversation

@Guardiola31337
Copy link
Copy Markdown
Contributor

Description

Fixes NavigationLauncherActivity incorrect profile regression from #1884

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

The goal here is that NavigationLauncherActivity test app example works as expected. It wasn't working because the profile from preferences was incorrect from some changes introduced in a previous PR

Implementation

The profile is case sensitive so passing for example Driving ends up in a {"message":"Not Found"} from the Directions API which left NavigationLauncherActivity in a spinning state

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed)
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@Guardiola31337 Guardiola31337 added this to the v0.37.0 milestone Apr 29, 2019
@Guardiola31337 Guardiola31337 self-assigned this Apr 29, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1914 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1914   +/-   ##
=========================================
  Coverage     36.33%   36.33%           
  Complexity     1087     1087           
=========================================
  Files           261      261           
  Lines          8874     8874           
  Branches        668      668           
=========================================
  Hits           3224     3224           
  Misses         5358     5358           
  Partials        292      292

Copy link
Copy Markdown
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Guardiola31337 🚢

@Guardiola31337 Guardiola31337 merged commit dbc500a into master Apr 29, 2019
@Guardiola31337 Guardiola31337 deleted the pg-profile-testapp-revert branch April 29, 2019 20:30
@danesfeder danesfeder mentioned this pull request May 1, 2019
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Defect to be fixed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants