Fix Navigation Launcher test app Activity incorrect profile regression#1914
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
=========================================
Coverage 36.33% 36.33%
Complexity 1087 1087
=========================================
Files 261 261
Lines 8874 8874
Branches 668 668
=========================================
Hits 3224 3224
Misses 5358 5358
Partials 292 292 |
danesfeder
approved these changes
Apr 29, 2019
Contributor
danesfeder
left a comment
There was a problem hiding this comment.
Thanks @Guardiola31337 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
NavigationLauncherActivityincorrect profile regression from #1884bug,feature,new API(s),SEMVER, etc.)Goal
The goal here is that
NavigationLauncherActivitytest app example works as expected. It wasn't working because the profile from preferences was incorrect from some changes introduced in a previous PRImplementation
The
profileis case sensitive so passing for exampleDrivingends up in a{"message":"Not Found"}from the Directions API which leftNavigationLauncherActivityin a spinning stateTesting
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed)Checklist