Reset Navigator state#2850
Merged
Merged
Conversation
…ssion shutdown api
Codecov Report
@@ Coverage Diff @@
## master #2850 +/- ##
============================================
- Coverage 35.43% 35.43% -0.01%
Complexity 2101 2101
============================================
Files 544 544
Lines 19536 19539 +3
Branches 1841 1841
============================================
+ Hits 6922 6923 +1
- Misses 11788 11790 +2
Partials 826 826 |
abhishek1508
approved these changes
Apr 29, 2020
kmadsen
approved these changes
Apr 29, 2020
kmadsen
reviewed
Apr 29, 2020
| * Reset resources. | ||
| */ | ||
| override fun reset() { | ||
| navigator = Navigator() |
Contributor
There was a problem hiding this comment.
probably want to reset the other things, like route
This was referenced Apr 29, 2020
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resets
Navigatorwhen in onTripSession#stopand renamesDirectionsSessionshutdownAPIFixes #2769
bug,feature,new API(s),SEMVER, etc.)Goal
As
MapboxNativeNavigatorImplis a singleton (object)Navigatoris retained between sessions causing unexpected behaviors as the internal cache is not resetImplementation
resetAPI toMapboxNativeNavigatorand recreateNavigatorwhenMapboxNativeNavigatorImpl#resetMapboxDirectionsSessionshutdown API fromshutdownSessiontoshutdownTesting
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PRcc @kmadsen @cafesilencio @SiarheiFedartsou