Reset route and routeBufferGeoJson as part of MapboxNativeNavigatorImpl#reset#2852
Merged
Conversation
abhishek1508
approved these changes
Apr 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #2852 +/- ##
============================================
+ Coverage 35.00% 35.41% +0.40%
+ Complexity 2107 2101 -6
============================================
Files 541 544 +3
Lines 19422 19541 +119
Branches 1841 1841
============================================
+ Hits 6799 6920 +121
+ Misses 11807 11794 -13
- Partials 816 827 +11 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resets
routeandrouteBufferGeoJsonas part ofMapboxNativeNavigatorImpl#resetFollow up from #2850 (comment)
bug,feature,new API(s),SEMVER, etc.)Goal
Tailwork from #2850
Implementation
Testing
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed) through testapp/demo app and run all activities to avoid regressionsChecklist
CHANGELOGincluding this PRcc @kmadsen