Enable proactive rerouting by default

[frederoni]

Fixes #1902 - Enable proactive rerouting by default

• Reuse proactive rerouting from LegacyRouteController
• Add tests

[1ec5]

We’re getting close to being able to refresh the existing route on a timer as well. Should we control both behaviors through a single, more generically named property, on an interval defined by a single, more generically named constant? Or should we keep the two complementary behaviors separate?

[akitchen]

I think it's OK to keep a separate flag for "reroutesProactively" (although the naming leaves a little to be desired). Faster route polling should happen directly after a directions refresh response, so it's possible we'll be reworking this code again soon.

I don't think we should combine them into one option, to directly answer your question.

[noway]

what does 'refresh the existing route' mean? separate i reckon, by the sound of it.

[1ec5]

Suggested changelog entry:

• Restored the RouteController.reroutesProactively property. (#1986)
• Added a RouteControllerMinimumDurationRemainingForProactiveRerouting global variable to customize when RouteController stops looking for more optimal routes as the user nears the destination. (#1986)

[frederoni]

This line introduces a deprecation warning. Not sure how to work around that 🤔