Reset last proactive request date before sending request.#1990
Closed
Woildan wants to merge 0 commit into
Closed
Conversation
Contributor
Contributor
Author
|
After a quick look at your code it looks like it should fix my problem. |
d63f365 to
f7a650c
Compare
f7a650c to
c950c2f
Compare
Contributor
Author
|
Fix looks good, I'm throwing my branch away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another fix I have in my codebase that I didn't contribute back until now.
The problem occurs when you have a server that takes more than a second to return a response to a proactive route update request (slow server or slow network).
When the next CoreLocation update is delivered to the route controller, if the pre-conditions are still met in didUpdateLocations, checkForFasterRoute gets called again, the elapsed time is still > to RouteControllerProactiveReroutingInterval, getDirections is called, previous request is cancelled, new one is sent.
As a result, when a proactive request is sent, another one will be sent every second until the server is able to send a response in less than a second.
Reseting the last update date before sending the request avoids re-sending a request before a full RouteControllerProactiveReroutingInterval seconds passes.