Lanes view filtering#3903
Merged
Merged
Conversation
bamx23
reviewed
May 20, 2022
| } | ||
|
|
||
| guard !subviews.isEmpty && subviews.contains(where: { !$0.isValid }) else { | ||
| guard !subviews.isEmpty && subviews.contains(where: { $0.isValid }) else { |
Contributor
There was a problem hiding this comment.
Are we checking that "all subviews are valid" or "any subview is valid"?
Suggested change
| guard !subviews.isEmpty && subviews.contains(where: { $0.isValid }) else { | |
| guard !subviews.isEmpty && subviews.allSatisfy({ $0.isValid }) else { |
Contributor
Author
There was a problem hiding this comment.
We are checking that at least 1 subview is valid
bamx23
approved these changes
May 20, 2022
bamx23
reviewed
May 20, 2022
Co-authored-by: Nikolay Volosatov <mikalai.valasatau@mapbox.com>
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR removes hiding lanes view when all of the suggested lanes are valid for the current route. This is done for parity with Android and for additional user info since it may still matter and affect lane selection to avoid slow left/right turning lanes on the way
Implementation
Replaced filtering check with a sanity check that at least 1 of the proposed lanes is valid.