Alternate Top Banner Instructions by vincethecoder · Pull Request #2149 · mapbox/mapbox-navigation-ios

vincethecoder · 2019-06-14T15:34:08Z

This effort creates a custom top banner instructions a.k.a Instructions Cards. This subscribes to the top banner configured in the route options used in creating a Navigation ViewController.

This top banner instructions component permits customization of the prototype card size, displayed instructions and the desired card style.

TODO

Add snapshot tests for cards with maneuver instructions
Design review complete
Fix broken tests
Test drive
~~Add snapshot tests for cards with next banner and lane indication(s) instructions~~
~~Provide the ability to customize the data sent to the dataSource~~

/cc @JThramer @frederoni @1ec5 @d-prukop @okoriep

… efforts.

…card view layout.

…ons cards.

…he recenter button was tapped.

…collection view's width.

…ner"

…rth with expected results.

…t might be consumed in refreshing the remaining steps.

…structions card view.

…gethers.

…oved commented out code. Refactored hardcoded cell identifier. Deleted the computed extension on Route residing within the card collection.

…uctions-card # Conflicts: # MapboxNavigation/NavigationInteractionDelegate.swift # MapboxNavigation/NavigationViewController.swift # MapboxNavigation/RouteMapViewController.swift

…uctions-card # Conflicts: # MapboxNavigation/RouteMapViewController.swift

…tests.

…apshot directory

1ec5 · 2019-08-02T23:08:15Z

+        instructionsCardView.updateDistanceFromCurrentLocation(distance)
+        instructionsCardView.step = step
+
+        // TODO: Merge Instructions Card, Lanes & Next Banner View Instructions


To do: figure out what this to-do means.

…rmittently not update.

JThramer · 2019-08-15T22:47:10Z

Posterity: This PR should be good to merge. Multi-leg support for guidance-cards, tracked in #2176, will be follow-on tail work, and as such all classes in this PR are marked /// :nodoc: until we are ready to announce the new feature.

/cc @mapbox/navigation-ios

1ec5 · 2019-08-22T19:27:19Z

Still getting failures on the Xcode 10.2 / iOS 12.2 CI bot:

/Users/distiller/project/MapboxNavigationTests/GuidanceCardsSnapshotTests.swift:59: error: -[MapboxNavigationTests.GuidanceCardsSnapshotTests testLanesManeuver] : failed - Snapshot comparison failed: Optional(Error Domain=FBSnapshotTestControllerErrorDomain Code=4 "Images different" UserInfo={NSLocalizedFailureReason=image pixels differed by more than 0.00% from the reference image, FBDiffedImageKey=<UIImage: 0x6000013f3b80>, {375, 812}, FBReferenceImageKey=<UIImage: 0x6000013f8690>, {375, 812}, FBCapturedImageKey=<UIImage: 0x6000013f3bf0>, {375, 812}, NSLocalizedDescription=Images different})

The test fixture was generated in Xcode 10.3 with an iOS 12.2 simulator.

1ec5 · 2019-08-23T00:42:44Z

Despite the test fixtures’ file names, the tests are apparently being run on a device other than iPhone X. I see no reason to believe it’d be anything other than iPhone 6 Plus, which is what the CircleCI configuration specifies.

Expected	Actual

At the same time, I think it’s unfortunate that the next guidance card would peek in a bit more on one device than another. Either we only want enough of the card to peek in so that the user can tell the cards are swipable, or we want enough to peek in to characterize the following maneuver.

1ec5 · 2019-08-24T03:06:21Z

Once we address tail work such as #2175 and #2176, we’ll want to mention this feature and all its API implications in the changelog.

vincethecoder and others added 30 commits April 22, 2019 13:42

WIP - initial instructions card integration for the custom top banner…

c79e9f5

… efforts.

Updates to resolve broken constraints. Created a custom instructions …

583575e

…card view layout.

Added ability to preview routes while scrolling through the instructi…

d8ae437

…ons cards.

Added navigation interaction delegate for sending messages whenever t…

fc08027

…he recenter button was tapped.

Added implementation to recover from preview mode.

5affdf4

Displays the appropriate instructions for the current maneuvers.

f3132a5

Added snapshot tests before upcoming cards refactor.

5ffec1b

Added test cases for the size and position of the instructions cards.

2479706

Added a unit and UI tests for the instructions cards.

1f10807

Fixed broken route preview.

81d0fcf

Updated the width of the cards using a percentile calculation of the …

cd9ba2b

…collection view's width.

Updated current branch with upstream branch "jerrad/customize-top-ban…

9b3fb20

…ner"

Refactored the modified steps variables to card steps.

3521993

Added a test to validate the instructions card collection delegate.

24b00a9

Updated current branch with upstream branch "jerrad/customize-top-ban…

986717d

…ner"

Updated compare images post merging jerrad's custom top banner branch.

704e123

Updates to instructions card collections to allow swiping back and fo…

16ab6e6

…rth with expected results.

Refactor to avoid using computed properties. Uncommented a method tha…

789b610

…t might be consumed in refreshing the remaining steps.

Deleted the redundant UI test file dedicated to instructions card.

e6f57ae

Added factory methods and deleted a few computed properties in the in…

4413886

…structions card view.

Removed commented code along. Minor changes to group class methods to…

35b8f9c

…gethers.

Added documentation to the instructions card collection delegate. Rem…

d89dab3

…oved commented out code. Refactored hardcoded cell identifier. Deleted the computed extension on Route residing within the card collection.

Merge branch 'jerrad/customize-top-banner' into kobe/top-banner-instr…

2df5532

…uctions-card # Conflicts: # MapboxNavigation/NavigationInteractionDelegate.swift # MapboxNavigation/NavigationViewController.swift # MapboxNavigation/RouteMapViewController.swift

Temporary setting to mapbox mobile events to 0.8.1 to experimentation.

9a808a8

Merge branch 'jerrad/customize-top-banner' into kobe/top-banner-instr…

c3b6478

…uctions-card # Conflicts: # MapboxNavigation/RouteMapViewController.swift

Updated mobile events version to latest release.

fc8a74f

Updates to use generic view width to fix the broken snapshot tests.

6fc7ba5

Providing 12.2 snapshot for kobe as requested

25c7fb3

Regenerated the snapshot images to broken instructions card snapshot …

d92daba

…tests.

Deleted redundant reference images stored in the instructions card sn…

41872ae

…apshot directory

Guardiola31337 assigned JThramer Jul 22, 2019

1ec5 reviewed Aug 2, 2019

View reviewed changes

1ec5 reviewed Aug 3, 2019

View reviewed changes

Comment thread MapboxNavigation/InstructionsCardContainerView.swift Outdated

Jerrad Thramer added 5 commits August 9, 2019 14:38

Fixing redundant checks that were causing lanes & next banner to inte…

5a17173

…rmittently not update.

Merge branch 'master' into kobe/top-banner-instructions-card

3184056

Adding snapshot tests to guidance card collection.

01f932f

Adding :nodoc: to all unannounced classes

93a6a80

Extracted common test code into extension.

cbf7f5c

JThramer approved these changes Aug 15, 2019

View reviewed changes

1ec5 added 2 commits August 22, 2019 11:16

Added snapshot test fixtures

2ab971b

More guidance card snapshot test fixtures

d51ddff

Upgraded to Xcode 10.3

89eb721

1ec5 mentioned this pull request Aug 23, 2019

Guidance Cards - Snapshot tests to harden visual outputs. #2174

Closed

Jerrad Thramer added 4 commits August 23, 2019 17:07

Correcting issue with snapshot test failures.

cf992d2

oopsie.

59028e6

Fixup final issue with tests

fd9a3a4

Spoke too soon, hopefully this is the final time

e5f1b5a

JThramer removed the wip label Aug 24, 2019

JThramer merged commit 7dc790e into master Aug 24, 2019

1ec5 deleted the kobe/top-banner-instructions-card branch August 24, 2019 03:04

1ec5 added this to the v0.37.0 milestone Aug 24, 2019

1ec5 mentioned this pull request Aug 30, 2019

Fix CarPlay example build #2220

Merged

1ec5 mentioned this pull request Apr 1, 2020

Guidance Cards - multi-leg routes. #2176

Closed

1ec5 mentioned this pull request Sep 14, 2020

Document guidance cards, junction views #2627

Merged

1ec5 mentioned this pull request May 17, 2021

Expose maneuvers swipe ahead behavior mapbox/mapbox-navigation-android#4401

Open

1ec5 mentioned this pull request May 20, 2022

Lanes view filtering #3903

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alternate Top Banner Instructions#2149

Alternate Top Banner Instructions#2149
JThramer merged 76 commits into
masterfrom
kobe/top-banner-instructions-card

vincethecoder commented Jun 14, 2019 •

edited

Loading

Uh oh!

1ec5 Aug 2, 2019

Uh oh!

Uh oh!

JThramer commented Aug 15, 2019

Uh oh!

1ec5 commented Aug 22, 2019 •

edited

Loading

Uh oh!

1ec5 commented Aug 23, 2019

Uh oh!

1ec5 commented Aug 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

vincethecoder commented Jun 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

1ec5 Aug 2, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JThramer commented Aug 15, 2019

Uh oh!

1ec5 commented Aug 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

1ec5 commented Aug 23, 2019

Uh oh!

1ec5 commented Aug 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vincethecoder commented Jun 14, 2019 •

edited

Loading

1ec5 commented Aug 22, 2019 •

edited

Loading