Skip to content

Comments

fix: remove NaN from number plugin#7364

Merged
mscolnick merged 2 commits intomainfrom
ms/remove-nan-fromnumberplugin
Dec 3, 2025
Merged

fix: remove NaN from number plugin#7364
mscolnick merged 2 commits intomainfrom
ms/remove-nan-fromnumberplugin

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Dec 1, 2025

Fixes #7352, although I think the underlying issue/fix is #7363

I plan to follow up with more tests/updates to other places where this could crop up.

@vercel
Copy link

vercel bot commented Dec 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Dec 1, 2025 7:38pm

@Light2Dark
Copy link
Collaborator

Light2Dark commented Dec 2, 2025

Any thoughts on just doing #7363 fix & keep the tests + value ?? NaN? I think it's okay to have it as NaN

@mscolnick
Copy link
Contributor Author

@Light2Dark - the plugin state should be serializable, and NaN will just get serialized to null. i think its ok to do that here as well (being defensive twice, since this could come up again)

@mscolnick mscolnick merged commit 7a4da52 into main Dec 3, 2025
30 of 33 checks passed
@mscolnick mscolnick deleted the ms/remove-nan-fromnumberplugin branch December 3, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mo.ui.number().form() disappears after submitting empty value

2 participants