Updates to tests for restricted rooms based on changes to MSC3083.#145
Merged
Updates to tests for restricted rooms based on changes to MSC3083.#145
Conversation
clokep
force-pushed
the
clokep/restricted-auth
branch
from
3011843 to
2a154dc
Compare
babolivier
approved these changes
Jul 21, 2021
Contributor
babolivier
left a comment
babolivier
left a comment
There was a problem hiding this comment.
A few more details needed in comments but otherwise lgtm
Member
Author
|
Thanks! I also updated the overall comment for the test since it was quite confusing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponds to matrix-org/synapse#10254: