Attempt to pull the corresponding Synapse branch when running tests.#177
Merged
Attempt to pull the corresponding Synapse branch when running tests.#177
Conversation
clokep
force-pushed
the
clokep/corresponding-branch
branch
from
b4ca324 to
4ae005c
Compare
clokep
force-pushed
the
clokep/corresponding-branch
branch
from
4ae005c to
034810f
Compare
anoadragon453
approved these changes
Jul 26, 2021
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
We'll need to generalise this further once other homeserver's (that aren't on github.com/matrix-org/...) get added to the remit, but this works well for now 🙂
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: "Checkout corresponding ${{ matrix.homeserver }} branch" | ||
| if: ${{ matrix.homeserver == 'Synapse' }} |
Member
There was a problem hiding this comment.
We should perhaps put in a comment here to explain why Dendrite doesn't need this.
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches matrix-org/pipelines#158, but for GHA.
The code is cribbed from matrix-org/synapse#10160, and made somewhat homeserver-agnostic, but it seems that Dendrite actually pulls the code it needs as part of building the Docker image, so it is quite different.
This fixes the tests in #145