Merged
Conversation
Ensure that `state` is calculated correctly for archived rooms, even when there are no events returned in the timeline.
erikjohnston
reviewed
Apr 3, 2024
|
|
||
| exhaustiveResCheck := func(result gjson.Result, origin string) { | ||
| roomRes := result.Get("rooms.leave." + client.GjsonEscape(roomID)) | ||
| t.Run("timeline has events", func(t *testing.T) { |
Member
There was a problem hiding this comment.
Can we comment on what each of these subtests are testing here please? (I know this one toy didn't add, but since you're here...)
Member
Author
There was a problem hiding this comment.
Have added a couple of comments - are they clear enough?
erikjohnston
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that
stateis calculated correctly for archived rooms, even when there are no events returned in the timeline.cf element-hq/synapse#16932