MSC3291: Muting in VoIP calls by SimonBrandner · Pull Request #3291 · matrix-org/matrix-spec-proposals

SimonBrandner · 2021-07-22T12:44:02Z

Requires: #3077
Rendered

js-sdk implementation
react-sdk implementation

Thanks to @dbkr for help with this!

FCP tickyboxes

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

proposals/3291-muting.md

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

anoadragon453

Looks generally sensible so far!

proposals/3291-muting.md

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

proposals/3291-muting.md

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

anoadragon453

LGTM!

proposals/3291-muting.md

anoadragon453 · 2023-07-03T08:53:33Z

proposals/3291-muting.md

+(as defined in [MSC2746](https://github.com/matrix-org/matrix-doc/pull/2746)).
+While this solution might be the most flexible solution as it would allow
+clients to choose between bandwidth and a mute state change delay for each
+track, it would be harder to implement and feels generally disjointed.


I'm going to assume not and resolve this thread. Please re-open if you believe otherwise.

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

turt2live · 2023-07-04T03:23:22Z

@mscbot resolve review comments up to June 6, 2023

proposals/3291-muting.md

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

mscbot · 2023-07-11T14:14:21Z

🔔 This is now entering its final comment period, as per the review above. 🔔

mscbot · 2023-07-16T14:14:32Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

* MSC: Muting in VoIP calls Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Update MSC number Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Missing : Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Fix MSC number in prefix Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Fix unstable prefix table Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Reword pottential issues Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Add an Alternatives section Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Remove trailing comma Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix a typo Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix missing word Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Link to MSC for holding Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Update unstable prefixes Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Simplify things Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Be explicit about deps Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Be clearer about how things work Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Update proposals/3291-muting.md Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * `disabled` -> `enabled` Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Fix client mention Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Improve explaination Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Be more precise Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix negation Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Don't refer to something that doesn't exist Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> --------- Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

turt2live · 2024-03-19T19:05:39Z

Spec PR: matrix-org/matrix-spec#1755

richvdh · 2024-03-26T19:11:11Z

Merged! 🎉

MSC: Muting in VoIP calls

78bfa25

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner changed the title ~~MSC: Muting in VoIP calls~~ MSC3291: Muting in VoIP calls Jul 22, 2021

SimonBrandner added 3 commits July 22, 2021 14:44

Update MSC number

a3d1abc

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Missing :

57a6330

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Fix MSC number in prefix

7658c4a

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

ara4n reviewed Jul 22, 2021

View reviewed changes

proposals/3291-muting.md Outdated Show resolved Hide resolved

ara4n reviewed Jul 22, 2021

View reviewed changes

proposals/3291-muting.md Outdated Show resolved Hide resolved

turt2live added kind:core MSC which is critical to the protocol's success proposal A matrix spec change proposal proposal-in-review voip needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jul 23, 2021

SimonBrandner added 3 commits July 23, 2021 07:55

Fix unstable prefix table

2130df9

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Reword pottential issues

3a9701d

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Add an Alternatives section

d809c3b

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

anoadragon453 reviewed Jul 26, 2021

View reviewed changes

SimonBrandner and others added 4 commits July 26, 2021 15:25

Remove trailing comma

67168b3

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Fix a typo

ec24d95

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Fix missing word

0c01908

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Link to MSC for holding

cc8b73a

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

SimonBrandner commented Jul 27, 2021

View reviewed changes

proposals/3291-muting.md Outdated Show resolved Hide resolved

Update unstable prefixes

f1ac61f

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

This was referenced Jul 27, 2021

Support for MSC3291: Muting in VoIP calls matrix-org/matrix-js-sdk#1812

Merged

Figure out muting in VoIP calls element-hq/element-web#16862

Closed

dbkr removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Aug 2, 2021

germain-gg mentioned this pull request Aug 11, 2021

Stopping the camera whilst screensharing does not turn the webcam LED off on my mac element-hq/element-web#18456

Closed

SimonBrandner mentioned this pull request Aug 24, 2021

User Avatars element-hq/element-call#12

Closed

SimonBrandner changed the base branch from old_master to main August 30, 2021 16:00

SimonBrandner changed the base branch from main to old_master August 30, 2021 16:00

turt2live force-pushed the old_master branch from e895827 to dca99ee Compare August 30, 2021 22:34

anoadragon453 approved these changes Jul 3, 2023

View reviewed changes

SimonBrandner and others added 2 commits July 3, 2023 16:35

Be more precise

56d3541

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Fix negation

8905378

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label Jul 4, 2023

turt2live removed their request for review July 4, 2023 03:23

richvdh reviewed Jul 4, 2023

View reviewed changes

proposals/3291-muting.md Outdated Show resolved Hide resolved

Don't refer to something that doesn't exist

4da6f86

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 11, 2023

mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 16, 2023

turt2live merged commit ab26f19 into matrix-org:old_master Jul 16, 2023

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jul 16, 2023

SimonBrandner deleted the msc/muting branch August 22, 2023 12:07

turt2live mentioned this pull request Mar 12, 2024

Matrix 1.10 matrix-org/matrix-spec#1743

Closed

23 tasks

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Mar 19, 2024

richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Mar 26, 2024

This was referenced Apr 19, 2024

events: Add unstable support for muting in VoIP calls ruma/ruma#1781

Merged

Implement Matrix 1.11 changes ruma/ruma#1782

Closed

turt2live mentioned this pull request Jul 5, 2024

Declare support for Matrix v1.11 element-hq/synapse#17402

Closed

20 tasks

Conversation

SimonBrandner commented Jul 22, 2021 • edited by ara4n Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anoadragon453 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anoadragon453 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anoadragon453 Jul 3, 2023

Choose a reason for hiding this comment

Uh oh!

turt2live commented Jul 4, 2023

Uh oh!

Uh oh!

mscbot commented Jul 11, 2023

Uh oh!

mscbot commented Jul 16, 2023

Uh oh!

turt2live commented Mar 19, 2024

Uh oh!

richvdh commented Mar 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

SimonBrandner commented Jul 22, 2021 •

edited by ara4n

Loading