-
Notifications
You must be signed in to change notification settings - Fork 423
MSC3821: Update the redaction rules, again #3821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b2b4a74
Start an MSC2176 2.0
turt2live 06a4683
Merge branch 'main' into travis/msc/redaction-rules-change-again
turt2live 0d25dac
Remove scary warning about unstable implementation
turt2live cd9c012
Update spec links
turt2live 21f3bb1
Apply suggestions from code review
turt2live cccb646
Rewrite words into order that sense make
turt2live 82812b0
Update intro & unstable prefix history
turt2live File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Update redaction rules, again | ||
|
|
||
| The current [redaction algorithm](https://spec.matrix.org/v1.6/rooms/v9/#redactions) are | ||
| still missing some key fields, even after [MSC2176](https://github.com/matrix-org/matrix-spec-proposals/pull/2176) | ||
| attempted to fix some of the obvious cases. This MSC aims to fix more fields. | ||
|
|
||
| ## Proposal | ||
|
|
||
| *Note*: It is recommended to read [MSC2176](https://github.com/matrix-org/matrix-spec-proposals/pull/2176) | ||
| before this proposal as MSC2176 contains a lot of backing context. | ||
|
|
||
| In a new room version due to redactions affecting event hashes, we: | ||
turt2live marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| * `m.room.member` events additionally preserve part of `third_party_invite` under `content`, if present: | ||
clokep marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * Spec: https://spec.matrix.org/v1.6/client-server-api/#mroommember | ||
| * Under `third_party_invite`, `signed` is preserved. Rationale being that the `signed` block is required | ||
| for the server to validate the event, however excess fields and `display_name` are not as important. | ||
turt2live marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| Clients which are trying to represent a redacted `m.room.member` event with `third_party_invite` should | ||
| not rely on `display_name` being present but rather state "Bob accepted a third party invite" or similar. | ||
turt2live marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Unstable prefix | ||
|
|
||
| Implementations looking to test these changes before adopted into a stable room version should use | ||
| `org.matrix.msc3821.opt1` as the room version, using v9 as a base and treating it as unstable. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.