Skip to content

Copy GHA config for releasing to PyPI from s3 storage provider #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DMRobertson wants to merge 3 commits into from
Closed

Copy GHA config for releasing to PyPI from s3 storage provider #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5dbaa8
Import release.yml from synapse-s3-storage-provider
Jan 10, 2022
39f52c7
Use py 3.x; refer to packaging guide
Jan 10, 2022
7aef876
add CI step which checks the package can be built
Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions {{ cookiecutter.directory_name }}/.github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,17 @@ jobs:
- run: python -m pip install tox
- run: tox -e py

check-build:
name: Build and check Python package
runs-on: "ubuntu-latest"
steps:
- uses: "actions/checkout@v2"
- uses: "actions/setup-python@v2"
with:
python-version: "3.x"
- name: "Install packaging tools"
run: "python -m pip install --upgrade build twine"
- name: "Build dist package"
run: "python -m build"
- name: "Run twine checks"
run: "python -m twine check dist/*"
28 changes: 28 additions & 0 deletions {{ cookiecutter.directory_name }}/.github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# See also https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

name: "Build and upload to PyPI"
on:
release:
types: ["published"]

jobs:
build:
runs-on: "ubuntu-latest"
steps:
- uses: "actions/checkout@v2"

Copy link
Contributor

@squahtx squahtx Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitty nit: We've got difference whitespace styles here and in ci.yml. As a template I'd prefer it if we were consistent.

- uses: "actions/setup-python@v2"
with:
python-version: "3.x"
Copy link
Contributor

@squahtx squahtx Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Python version matter here? I suppose not.


- name: "Install packaging tools"
run: "python -m pip install --upgrade build twine"

- name: "Build dist package"
run: "python -m build"

- name: "Upload to PyPI"
run: "python -m twine upload dist/*"
env:
TWINE_USERNAME: "__token__"
TWINE_PASSWORD: "${{ secrets.PYPI_API_TOKEN }}"