Copy GHA config for releasing to PyPI from s3 storage provider#23
Copy GHA config for releasing to PyPI from s3 storage provider#23DMRobertson wants to merge 3 commits intomainfrom
Conversation
squahtx
left a comment
There was a problem hiding this comment.
Do we want to update the release instructions in the templated README too?
We could do it as part of a different PR if you prefer.
|
|
||
| - uses: "actions/setup-python@v2" | ||
| with: | ||
| python-version: "3.x" |
There was a problem hiding this comment.
Does the Python version matter here? I suppose not.
| runs-on: "ubuntu-latest" | ||
| steps: | ||
| - uses: "actions/checkout@v2" | ||
|
|
There was a problem hiding this comment.
nitty nit: We've got difference whitespace styles here and in ci.yml. As a template I'd prefer it if we were consistent.
|
Thanks for taking a look Sean. On reflection I'm wondering if it might make more sense to define a |
This is matrix-org/backend-meta#4. |
matrix-org/synapse-s3-storage-provider#69 and matrix-org/synapse-s3-storage-provider#70 but for the generic template.
This will have the following effects:
PYPI_API_TOKENsecret set and will fail otherwise.