Skip to content

[Designer] Add help button and dialog#4849

Merged
paulcam206 merged 3 commits into
mainfrom
paulcam/designer-help-button
Sep 29, 2020
Merged

[Designer] Add help button and dialog#4849
paulcam206 merged 3 commits into
mainfrom
paulcam/designer-help-button

Conversation

@paulcam206

@paulcam206 paulcam206 commented Sep 29, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown
Member

Related Issue

Fixes VSO 24095095

Description

Add keyboard help toolbar button and dialog

Button:
image

Dialog:
image

How Verified

  • local build, dev tools, narrator
Microsoft Reviewers: Open in CodeFlow

@paulcam206 paulcam206 added Area-Accessibility Bugs around feature accessibility Area-Designer labels Sep 29, 2020
@ghost

ghost commented Sep 29, 2020

Copy link
Copy Markdown

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@golddove

golddove commented Sep 29, 2020

Copy link
Copy Markdown
Member

After closing the dialog w/ keyboard, the focus returns to the top of the page (above the UHF). Would it be possible to return focus to the help button?

@paulcam206

paulcam206 commented Sep 29, 2020

Copy link
Copy Markdown
Member Author

After closing the dialog w/ keyboard, the focus returns to the top of the page (above the UHF). Would it be possible to return focus to the help button?

yeah -- I'm going to have a separate PR for that. I also noticed tab navigation leaking out of the dialog, which is a broader bug that applies to all of our Dialog-derived experiences

RebeccaAnne
RebeccaAnne approved these changes Sep 29, 2020
View reviewed changes

@RebeccaAnne RebeccaAnne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@paulcam206
paulcam206 merged commit 56bd9d9 into main Sep 29, 2020
@paulcam206
paulcam206 deleted the paulcam/designer-help-button branch September 29, 2020 20:36
@paulcam206

paulcam206 commented Sep 29, 2020

Copy link
Copy Markdown
Member Author

After closing the dialog w/ keyboard, the focus returns to the top of the page (above the UHF). Would it be possible to return focus to the help button?

yeah -- I'm going to have a separate PR for that. I also noticed tab navigation leaking out of the dialog, which is a broader bug that applies to all of our Dialog-derived experiences

fixes in #4850

@ghost ghost removed the AdaptiveCards v20.09 label Sep 30, 2020
@golddove golddove mentioned this pull request Sep 30, 2020
Merged
golddove added a commit that referenced this pull request Oct 1, 2020
@golddove @paulcam206
[JavaScript] cherry-pick of #4848 and #4849 for release/20.09 (#4866)
bf9e6eb 
* [JavaScript] Strings shouldn't be const (#4858)

* [JS] Fix arrow keys and actionset aria (#4859)

Co-authored-by: Paul Campbell <paulcam@microsoft.com>
@ghost

ghost commented Oct 2, 2020

Copy link
Copy Markdown

🎉AdaptiveCards@2020.09 has been released which fixes this issue.:tada:

Handy links:

@MYBUSYBEEINC MYBUSYBEEINC mentioned this pull request Oct 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dclaux dclaux Awaiting requested review from dclaux
2 more reviewers
@golddove golddove golddove approved these changes
@RebeccaAnne RebeccaAnne RebeccaAnne approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Accessibility Bugs around feature accessibility Area-Designer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulcam206 @golddove @RebeccaAnne