Skip to content

[JavaScript] Strings shouldn't be const#4858

Merged
golddove merged 1 commit into
mainfrom
golddove/no-const
Sep 30, 2020
Merged

[JavaScript] Strings shouldn't be const#4858
golddove merged 1 commit into
mainfrom
golddove/no-const

Conversation

@golddove

@golddove golddove commented Sep 30, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown
Member

Description

Users of the SDK should be able to supply their own strings by modifying these properties.

How Verified

No verification, just restoring previous behavior

Microsoft Reviewers: Open in CodeFlow

@golddove
golddove requested a review from dclaux September 30, 2020 19:05
@ghost

ghost commented Sep 30, 2020

Copy link
Copy Markdown

Hi @golddove. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@golddove
golddove merged commit b2d2eef into main Sep 30, 2020
@golddove
golddove deleted the golddove/no-const branch September 30, 2020 20:10
golddove added a commit that referenced this pull request Sep 30, 2020
@golddove
[JavaScript] Strings shouldn't be const (#4858)
69106fe
golddove added a commit that referenced this pull request Oct 1, 2020
@golddove @paulcam206
[JavaScript] cherry-pick of #4848 and #4849 for release/20.09 (#4866)
bf9e6eb 
* [JavaScript] Strings shouldn't be const (#4858)

* [JS] Fix arrow keys and actionset aria (#4859)

Co-authored-by: Paul Campbell <paulcam@microsoft.com>
@MYBUSYBEEINC MYBUSYBEEINC mentioned this pull request Oct 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dclaux dclaux dclaux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@golddove @dclaux