[FwUpdateCfu] Update config file to match CfuVirtualHid#65
Open
forderud wants to merge 2 commits into
Open
Conversation
The FwUpdateCfu config file is currently unable to detect & query version for the virtual HID device found in this repo (CfuVirtualHid). This PR seeks to fix this, so that the tool can at least query FW version. The PR require the PID/VID filtering fix in microsoft#64 to be merged first. Impact to functionality: * "FwUpdateCfu.exe version protocolCfgExample.cfg" is now able to successfully query FW version. * "FwUpdateCfu.exe update protocolCfgExample.cfg CfuVirtualHidDevice_MCU.offer.bin CfuVirtualHidDevice_MCU.payload.bin" still fails (not a regression in this PR). This will need to be addressed later. Changes to match defines in the CfuVirtualHid driver: * Change PID to match PRODUCT_ID. * Change USAGEPAGE to match CFU_DEVICE_USAGE_PAGE. * Change USAGECOLLECTION to match CFU_DEVICE_USAGE. * Change VERSION_FEATURE_USAGE to match VERSIONS_FEATURE_USAGE.
9dde8c8 to
389d104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FwUpdateCfu config file is currently unable to query version & update FW for the virtual HID device found in this repo (CfuVirtualHid). This PR seeks to fix this. The PR require #64 and #66 to be merged first.
Impact to functionality:
FwUpdateCfu.exe version protocolCfgExample.cfgis now able to successfully query FW version (see below).FwUpdateCfu.exe update protocolCfgExample.cfg CfuVirtualHidDevice_MCU.offer.bin CfuVirtualHidDevice_MCU.payload.binis now able to successfully update the FW version (see below).Changes to match defines in the CfuVirtualHid driver:
PIDto matchPRODUCT_IDUSAGEPAGEto matchCFU_DEVICE_USAGE_PAGEUSAGECOLLECTIONto matchCFU_DEVICE_USAGEVERSION_FEATURE_USAGEto matchVERSIONS_FEATURE_USAGECONTENT_OUTPUT_USAGEto matchPAYLOAD_OUTPUT_USAGECONTENT_RESPONSE_INPUT_USAGEto matchPAYLOAD_INPUT_USAGE_MINOFFER_OUTPUT_USAGEto matchOFFER_OUTPUT_USAGE_MINOFFER_RESPONSE_INPUT_USAGEto matchOFFER_INPUT_USAGE_MINFwUpdateCfu.exe output
Observed output when running
FwUpdateCfu.exe version protocolCfgExample.cfgwith this PR:Observed output when running
FwUpdateCfu.exe update protocolCfgExample.cfg CfuVirtualHidDevice_MCU.offer.bin CfuVirtualHidDevice_MCU.payload.binwith this PR: