[FwUpdateCfu] Fix failing HidD_SetOutputReport during FW update #66
Open
forderud wants to merge 2 commits into
Open
[FwUpdateCfu] Fix failing HidD_SetOutputReport during FW update #66forderud wants to merge 2 commits into
forderud wants to merge 2 commits into
Conversation
"deviceWrite" is only used for HidCommands::SetOutputReport calls that internally call HidD_SetOutputReport. This Win32 function require GENERIC_WRITE access, so the device permissions need to be updated accordingly.
…riteFile instead of HidD_SetOutputReport Done to fix problem of HidD_SetOutputReport calls failing with "The request is not supported" (0x32) errors. According to https://learn.microsoft.com/en-us/windows-hardware/drivers/hid/sending-hid-reports then some HID devices doesn't support HidD_SetOutputReport. Clients will then instead need to write output reports through WriteFile. CfuVirtualHid seems to be a such device.
This was referenced Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
deviceWrite.HidCommands::SetOutputReportto internally useWriteFileinstead ofHidD_SetOutputReportDone to fix problem of
HidD_SetOutputReportcalls failing with "The request is not supported" (0x32) errors.According to Sending HID reports then some HID devices doesn't support HidD_SetOutputReport. Clients then instead need to write output reports through WriteFile. CfuVirtualHid seems to be a such device.