Skip to content

Add godoc to mcptool AddTool/Connect/ListTools and fix agent.Tool references to tool.Tool #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PratikDhanave wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add godoc to mcptool AddTool/Connect/ListTools and fix agent.Tool references to tool.Tool #685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cee2a6f
Add godoc to mcptool AddTool/Connect/ListTools and fix agent.Tool ref…
PratikDhanave Jul 24, 2026
f3e01d2
docs: fix mcptool package godoc name and tool-only scope
PratikDhanave Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tool/mcptool/mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright (c) Microsoft. All rights reserved.

// Package mcp provides integration with the Model Context Protocol (MCP).
// Package mcptool provides integration with the Model Context Protocol (MCP).
// It allows agents to connect to external MCP servers via stdio, HTTP, or WebSocket
// and expose their tools and prompts as agent.Tool instances.
// and expose their tools as tool.Tool instances.
package mcptool

import (
Expand All @@ -18,6 +18,7 @@ import (
"github.com/modelcontextprotocol/go-sdk/mcp"
)

// AddTool registers a tool.FuncTool on the given mcp.Server so it is exposed to MCP clients.
func AddTool(src *mcp.Server, tl tool.FuncTool) {
src.AddTool(&mcp.Tool{
Name: tl.Name(),
Expand All @@ -35,6 +36,7 @@ func AddTool(src *mcp.Server, tl tool.FuncTool) {
})
}

// Connect dials an MCP server over the given transport and returns a client session.
func Connect(ctx context.Context, transport mcp.Transport) (*mcp.ClientSession, error) {
client := mcp.NewClient(&mcp.Implementation{
Name: "agent-framework-go-mcp-client",
Expand All @@ -43,13 +45,14 @@ func Connect(ctx context.Context, transport mcp.Transport) (*mcp.ClientSession,
return client.Connect(ctx, transport, nil)
}

// ListTools enumerates the remote server's tools and wraps each as a tool.Tool.
func ListTools(ctx context.Context, session *mcp.ClientSession) ([]tool.Tool, error) {
toolsResult, err := session.ListTools(ctx, nil)
if err != nil {
return nil, fmt.Errorf("failed to list tools: %w", err)
}

// Create agent.Tool instances for each MCP tool
// Create tool.Tool instances for each MCP tool
result := make([]tool.Tool, 0, len(toolsResult.Tools))
for _, mcpTool := range toolsResult.Tools {
agentTool := newMCPToolWrapper(session, mcpTool)
Expand Down Expand Up @@ -389,7 +392,7 @@ var (
_ tool.FuncTool = (*mcpWrapper)(nil)
)

// mcpWrapper wraps an MCP tool as an agent.Tool.
// mcpWrapper wraps an MCP tool as a tool.Tool.
type mcpWrapper struct {
session *mcp.ClientSession
tool *mcp.Tool
Expand Down
Loading