fix(wrapper): update smoke test to assert protocol 0.2.0#18
Merged
Conversation
PR #17 bumped PROTOCOL_VERSION_REQUIRED_BY_WRAPPER from 0.1.0 to 0.2.0 in wrappers/typescript/src/index.ts but missed the smoke test assertion. The publish-wrapper.yml workflow on the wrapper-v0.4.0 tag failed at the test stage (run #26550926394), preventing npm publish. This fixes the assertion to expect 0.2.0, unblocking the publish of amplifier-agent-ts@0.4.0 to npm. Local verification: 60/60 wrapper tests pass. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
manojp99
pushed a commit
to manojp99/amplifier-app-nanoclaw
that referenced
this pull request
May 28, 2026
…3.0 (protocol 0.2.0) Adopt the engine + wrapper coordinated fix from amplifier-agent PR #17 (protocol 0.2.0, path-based MCP config delivery) and the catalog fix from PR #20 (openai default_model gpt-5.5 to match the bundle's extended_thinking=true default). Engine pin: AMPLIFIER_AGENT_REF=engine-v0.3.0 in container/Dockerfile. The tag was moved to PR #20's merge commit so a rebuild pulls the catalog fix without needing a separate engine version bump. Layer-cache busting during rebuild required --no-cache (or BuildKit --no-cache-filter). A persistent CACHEBUST arg for the Dockerfile is a separate follow-up. Wrapper bump: amplifier-agent-ts 0.3.1 -> 0.4.0 (published with provenance via OIDC trusted publishing on the wrapper-v0.4.0 tag). Host + agent-runner code: drops the workarounds we'd been carrying for the engine's MCP plumbing bugs. The engine now handles --mcp-config-path end-to-end (validates the path, sets AMPLIFIER_MCP_CONFIG, lets the tool-mcp module discover via its documented config priority). The host-side bridge no longer needs to compensate. Verified end-to-end inside the rebuilt container: - amplifier-agent run --provider openai -y "..." returns a real reply through gpt-5.5 with extended_thinking=true flowing cleanly through loop-streaming -> provider-openai -> OpenAI API. - Engine envelope parseable on stdout, protocolVersion=0.2.0, metadata block present. Refs: - microsoft/amplifier-agent#17 (engine + wrapper Path D) - microsoft/amplifier-agent#18 (smoke test fix) - microsoft/amplifier-agent#19 (vitest timeout fix) - microsoft/amplifier-agent#20 (catalog gpt-5.5 default) - engine tag: engine-v0.3.0 -> commit 2bd951f - wrapper tag: wrapper-v0.4.0 -> commit 53f99bb Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #17 bumped
PROTOCOL_VERSION_REQUIRED_BY_WRAPPERfrom"0.1.0"→"0.2.0"inwrappers/typescript/src/index.tsbut missed the smoke test assertion that hardcoded the old value. Thepublish-wrapper.ymlworkflow on thewrapper-v0.4.0tag failed at the test stage:wrappers/typescript/test/smoke.test.ts:6npm view amplifier-agent-ts@0.4.0returns 404 — nothing was published.Fix
Update the assertion to expect
"0.2.0"to match the bumped constant.After this merges
Re-tag
engine-v0.3.0andwrapper-v0.4.0on the new merge commit (the original tags pointed at the broken commitea51d05; safe to move since 0.4.0 was never published). Thewrapper-v0.4.0tag push will re-trigger the publish workflow, which should now pass and shipamplifier-agent-ts@0.4.0to npm with provenance.Local verification