fix(wrapper): bump vitest testTimeout to 15s for CI transport test#19
Merged
Conversation
The publish-wrapper workflow times out on test/transport.test.ts > Transport > terminate() resolves with SIGTERM signal, which spawns a real subprocess and waits for SIGTERM exit. vitest's default 5s timeout is too tight on busy GitHub Actions runners. Bumping to 15s accommodates the real-world round-trip. Locally verified: 61/61 wrapper tests pass. Failing workflow run: https://github.com/microsoft/amplifier-agent/actions/runs/26551192854 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
manojp99
pushed a commit
to manojp99/amplifier-app-nanoclaw
that referenced
this pull request
May 28, 2026
…3.0 (protocol 0.2.0) Adopt the engine + wrapper coordinated fix from amplifier-agent PR #17 (protocol 0.2.0, path-based MCP config delivery) and the catalog fix from PR #20 (openai default_model gpt-5.5 to match the bundle's extended_thinking=true default). Engine pin: AMPLIFIER_AGENT_REF=engine-v0.3.0 in container/Dockerfile. The tag was moved to PR #20's merge commit so a rebuild pulls the catalog fix without needing a separate engine version bump. Layer-cache busting during rebuild required --no-cache (or BuildKit --no-cache-filter). A persistent CACHEBUST arg for the Dockerfile is a separate follow-up. Wrapper bump: amplifier-agent-ts 0.3.1 -> 0.4.0 (published with provenance via OIDC trusted publishing on the wrapper-v0.4.0 tag). Host + agent-runner code: drops the workarounds we'd been carrying for the engine's MCP plumbing bugs. The engine now handles --mcp-config-path end-to-end (validates the path, sets AMPLIFIER_MCP_CONFIG, lets the tool-mcp module discover via its documented config priority). The host-side bridge no longer needs to compensate. Verified end-to-end inside the rebuilt container: - amplifier-agent run --provider openai -y "..." returns a real reply through gpt-5.5 with extended_thinking=true flowing cleanly through loop-streaming -> provider-openai -> OpenAI API. - Engine envelope parseable on stdout, protocolVersion=0.2.0, metadata block present. Refs: - microsoft/amplifier-agent#17 (engine + wrapper Path D) - microsoft/amplifier-agent#18 (smoke test fix) - microsoft/amplifier-agent#19 (vitest timeout fix) - microsoft/amplifier-agent#20 (catalog gpt-5.5 default) - engine tag: engine-v0.3.0 -> commit 2bd951f - wrapper tag: wrapper-v0.4.0 -> commit 53f99bb Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
manojp99
added a commit
that referenced
this pull request
Jun 3, 2026
…0.6.1) (#37) The `test/transport.test.ts > terminate() resolves with SIGTERM signal or non-zero exit code` test exercises actual subprocess SIGTERM handling, which is slower on Ubuntu CI runners than on local macOS. The 0.6.0 publish-wrapper.yml workflow run failed at the Test step with `Error: Test timed out in 5000ms` before reaching `npm publish`. Per-test timeout bumped from 5s to 15s. Same class of fix as #19 fix(wrapper): bump vitest testTimeout to 15s for CI transport test from a prior release window. `amplifier-agent-ts@0.6.0` was never published to npm; this 0.6.1 release supersedes that aborted attempt. Consumers can install 0.6.1 directly without first installing 0.6.0. Local TS wrapper test results: 95 passed / 95. Co-authored-by: Manoj Prabhakar Paidiparthy <mpaidiparthy@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The publish-wrapper workflow keeps timing out on a single test in
test/transport.test.ts:Failing runs (after PR #17 + #18 merged and the
wrapper-v0.4.0tag was placed on the new merge commit):gh run rerun --failed(FAIL same way)The test spawns
sh -c "sleep 60", sends SIGTERM viaterminate(), then waits for the subprocess to exit. On a clean local machine it completes in <1s. On busy GitHub Actions runners it routinely exceeds vitest's 5s default.Fix
Bump global
testTimeoutto 15s inwrappers/typescript/vitest.config.ts. Comment in the config references this PR's context so future maintainers know why the default isn't 5s.Verification
After this merges
engine-v0.3.0andwrapper-v0.4.0get moved to the new merge commit; pushingwrapper-v0.4.0re-triggers the publish workflow and shipsamplifier-agent-ts@0.4.0to npm.