Skip to content

[Bug]: Spinner component fails accessibility. Need to add Stroke Alpha 2, Modify Brand Stroke 2 high contrast values. #28385

Description

@redongreen

Library

React Components / v9 (@fluentui/react-components)

System Info

https://master--628d031b55e942004ac95df1.chromatic.com/?path=/docs/components-spinner--default

Are you reporting Accessibility issue?

yes

Reproduction

https://master--628d031b55e942004ac95df1.chromatic.com/?path=/docs/components-spinner--default

Bug Description

Context

Currently spinner component primary variant is not accessible in high contrast.

CleanShot 2023-06-29 at 11 48 05

This is partially due to the fact that we never created a token to support the look and feel of our spinner spec. The spec originally instructed engineers to hard code a value in place.

Full HC audit can be found here; Figma link

To do

To fix the spinner, we need to add two new stroke tokens

Add new token

Add new token Neutral Stroke Alpha 2
Light theme: White 20% alpha
Dark theme: White 20% alpha
High contrast theme: hcCanvas #000000

CleanShot 2023-06-29 at 11 44 14@2x

Add new token Brand Stroke 2 Contrast
Light theme: Comm 140 #B4D6FA
Dark theme: Comm 50 #0E4775
High contrast theme: hcCanvas #000000

CleanShot 2023-07-10 at 16 30 58@2x

Update existing component

Ensure that we are following the updated token assignment. Link to component spec.

CleanShot 2023-07-10 at 16 36 15@2x

cc @daisygeng

Logs

https://master--628d031b55e942004ac95df1.chromatic.com/?path=/docs/components-spinner--default

Requested priority

High

Products/sites affected

https://master--628d031b55e942004ac95df1.chromatic.com/?path=/docs/components-spinner--default

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Metadata

Metadata

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions