Skip to content

feat: Update Spinner appearance token#29008

Merged
tomi-msft merged 2 commits into
microsoft:masterfrom
tomi-msft:spinner-hc-token-fix
Aug 29, 2023
Merged

feat: Update Spinner appearance token#29008
tomi-msft merged 2 commits into
microsoft:masterfrom
tomi-msft:spinner-hc-token-fix

Conversation

@tomi-msft

Copy link
Copy Markdown
Contributor

fixes #28385

@tomi-msft
tomi-msft requested a review from a team as a code owner August 28, 2023 22:14
@github-actions github-actions Bot added this to the August Project Cycle Q4 2023 milestone Aug 28, 2023
@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 639 588 5000
Button mount 325 310 5000
Field mount 1110 1103 5000
FluentProvider mount 694 702 5000
FluentProviderWithTheme mount 90 86 10
FluentProviderWithTheme virtual-rerender 72 86 10
FluentProviderWithTheme virtual-rerender-with-unmount 85 82 10
InfoButton mount 18 13 5000
MakeStyles mount 870 850 50000
Persona mount 1719 1646 5000
SpinButton mount 1361 1374 5000

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f2f4a65:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-spinner
Spinner
19.668 kB
7.024 kB
19.678 kB
7.03 kB
10 B
6 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
66.583 kB
18.469 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
203.817 kB
57.926 kB
react-components
react-components: FluentProvider & webLightTheme
37.926 kB
12.419 kB
react-portal-compat
PortalCompatProvider
6.48 kB
2.203 kB
🤖 This report was generated against ecaa08385bb0e25eafe87e3fb4424cb9139eea2d

@size-auditor

size-auditor Bot commented Aug 28, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ecaa08385bb0e25eafe87e3fb4424cb9139eea2d (build)

@tomi-msft
tomi-msft merged commit 919250f into microsoft:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Spinner component fails accessibility. Need to add Stroke Alpha 2, Modify Brand Stroke 2 high contrast values.

4 participants