(chore): Remove deprecated conformance tests#24063
Merged
tomi-msft merged 8 commits intoJul 27, 2022
Merged
Conversation
tomi-msft
requested review from
a team,
GeoffCoxMSFT,
behowell,
chpalac,
khmakoto,
ling1726,
micahgodbolt,
smhigley,
sopranopillow and
spmonahan
as code owners
July 25, 2022 19:26
…c-react into remove-unused-conformance-tests
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 15c5a64:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ee025ccd3a919f2f4dcdd3a74dbe6d2abfed24ff (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1308 | 1187 | 5000 | |
| Button | mount | 827 | 907 | 5000 | |
| FluentProvider | mount | 1567 | 1575 | 5000 | |
| FluentProviderWithTheme | mount | 636 | 607 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 584 | 585 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 620 | 610 | 10 | |
| MakeStyles | mount | 1910 | 1891 | 50000 | |
| SpinButton | mount | 2635 | 2525 | 5000 |
…8a31c73f5.json Co-authored-by: Esteban Munoz Facusse <esteban.230@hotmail.com>
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ListNestedPerf.default | 1387 | 452 | 3.07:1 |
| ProviderMinimalPerf.default | 343 | 299 | 1.15:1 |
| TreeWith60ListItems.default | 142 | 127 | 1.12:1 |
| GridMinimalPerf.default | 291 | 270 | 1.08:1 |
| ButtonMinimalPerf.default | 144 | 134 | 1.07:1 |
| CarouselMinimalPerf.default | 401 | 380 | 1.06:1 |
| AnimationMinimalPerf.default | 463 | 442 | 1.05:1 |
| DialogMinimalPerf.default | 650 | 622 | 1.05:1 |
| FlexMinimalPerf.default | 247 | 236 | 1.05:1 |
| HeaderSlotsPerf.default | 645 | 617 | 1.05:1 |
| ImageMinimalPerf.default | 311 | 297 | 1.05:1 |
| RefMinimalPerf.default | 208 | 198 | 1.05:1 |
| IconMinimalPerf.default | 511 | 485 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 246 | 237 | 1.04:1 |
| HeaderMinimalPerf.default | 305 | 292 | 1.04:1 |
| LayoutMinimalPerf.default | 296 | 285 | 1.04:1 |
| TableMinimalPerf.default | 346 | 333 | 1.04:1 |
| AlertMinimalPerf.default | 224 | 217 | 1.03:1 |
| ChatMinimalPerf.default | 631 | 611 | 1.03:1 |
| LabelMinimalPerf.default | 324 | 315 | 1.03:1 |
| ListWith60ListItems.default | 517 | 503 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1429 | 1390 | 1.03:1 |
| AttachmentSlotsPerf.default | 920 | 903 | 1.02:1 |
| CardMinimalPerf.default | 461 | 453 | 1.02:1 |
| ListMinimalPerf.default | 432 | 425 | 1.02:1 |
| SkeletonMinimalPerf.default | 287 | 280 | 1.02:1 |
| TableManyItemsPerf.default | 1600 | 1564 | 1.02:1 |
| TextMinimalPerf.default | 287 | 281 | 1.02:1 |
| AccordionMinimalPerf.default | 122 | 121 | 1.01:1 |
| AttachmentMinimalPerf.default | 126 | 125 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1267 | 1258 | 1.01:1 |
| DividerMinimalPerf.default | 296 | 294 | 1.01:1 |
| DropdownManyItemsPerf.default | 580 | 576 | 1.01:1 |
| InputMinimalPerf.default | 1089 | 1080 | 1.01:1 |
| LoaderMinimalPerf.default | 571 | 563 | 1.01:1 |
| RadioGroupMinimalPerf.default | 370 | 367 | 1.01:1 |
| SliderMinimalPerf.default | 1427 | 1417 | 1.01:1 |
| StatusMinimalPerf.default | 568 | 561 | 1.01:1 |
| TextAreaMinimalPerf.default | 407 | 402 | 1.01:1 |
| BoxMinimalPerf.default | 274 | 275 | 1:1 |
| CheckboxMinimalPerf.default | 2263 | 2263 | 1:1 |
| ItemLayoutMinimalPerf.default | 986 | 986 | 1:1 |
| ListCommonPerf.default | 525 | 523 | 1:1 |
| PopupMinimalPerf.default | 523 | 521 | 1:1 |
| PortalMinimalPerf.default | 142 | 142 | 1:1 |
| ProviderMergeThemesPerf.default | 1068 | 1066 | 1:1 |
| ReactionMinimalPerf.default | 309 | 308 | 1:1 |
| SegmentMinimalPerf.default | 288 | 288 | 1:1 |
| CustomToolbarPrototype.default | 2302 | 2293 | 1:1 |
| TreeMinimalPerf.default | 680 | 678 | 1:1 |
| DropdownMinimalPerf.default | 2631 | 2665 | 0.99:1 |
| EmbedMinimalPerf.default | 3404 | 3439 | 0.99:1 |
| FormMinimalPerf.default | 328 | 330 | 0.99:1 |
| MenuMinimalPerf.default | 707 | 711 | 0.99:1 |
| SplitButtonMinimalPerf.default | 3647 | 3678 | 0.99:1 |
| ToolbarMinimalPerf.default | 764 | 772 | 0.99:1 |
| TooltipMinimalPerf.default | 953 | 962 | 0.99:1 |
| ChatWithPopoverPerf.default | 303 | 309 | 0.98:1 |
| DatepickerMinimalPerf.default | 4841 | 4936 | 0.98:1 |
| RosterPerf.default | 906 | 922 | 0.98:1 |
| VideoMinimalPerf.default | 555 | 575 | 0.97:1 |
| ButtonSlotsPerf.default | 448 | 466 | 0.96:1 |
| AvatarMinimalPerf.default | 134 | 153 | 0.88:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 982 | 972 | 5000 | |
| Breadcrumb | mount | 2678 | 2715 | 1000 | |
| Checkbox | mount | 2701 | 2676 | 5000 | |
| CheckboxBase | mount | 2361 | 2324 | 5000 | |
| ChoiceGroup | mount | 4988 | 5027 | 5000 | |
| ComboBox | mount | 958 | 990 | 1000 | |
| CommandBar | mount | 10464 | 10624 | 1000 | |
| ContextualMenu | mount | 11038 | 11137 | 1000 | |
| DefaultButton | mount | 1178 | 1171 | 5000 | |
| DetailsRow | mount | 3997 | 4008 | 5000 | |
| DetailsRowFast | mount | 3925 | 3945 | 5000 | |
| DetailsRowNoStyles | mount | 3743 | 3813 | 5000 | |
| Dialog | mount | 2833 | 2863 | 1000 | |
| DocumentCardTitle | mount | 148 | 185 | 1000 | |
| Dropdown | mount | 3451 | 3471 | 5000 | |
| FocusTrapZone | mount | 1916 | 1865 | 5000 | |
| FocusZone | mount | 1773 | 1837 | 5000 | |
| IconButton | mount | 1864 | 1868 | 5000 | |
| Label | mount | 347 | 351 | 5000 | |
| Layer | mount | 3178 | 3152 | 5000 | |
| Link | mount | 492 | 486 | 5000 | |
| MenuButton | mount | 1553 | 1569 | 5000 | |
| MessageBar | mount | 2131 | 2186 | 5000 | |
| Nav | mount | 3465 | 3487 | 1000 | |
| OverflowSet | mount | 1095 | 1124 | 5000 | |
| Panel | mount | 2226 | 2221 | 1000 | |
| Persona | mount | 1042 | 1058 | 1000 | |
| Pivot | mount | 1474 | 1474 | 1000 | |
| PrimaryButton | mount | 1384 | 1372 | 5000 | |
| Rating | mount | 8218 | 8381 | 5000 | |
| SearchBox | mount | 1376 | 1351 | 5000 | |
| Shimmer | mount | 2613 | 2629 | 5000 | |
| Slider | mount | 2004 | 2013 | 5000 | |
| SpinButton | mount | 5177 | 5185 | 5000 | |
| Spinner | mount | 432 | 468 | 5000 | |
| SplitButton | mount | 3366 | 3351 | 5000 | |
| Stack | mount | 549 | 545 | 5000 | |
| StackWithIntrinsicChildren | mount | 2504 | 2454 | 5000 | |
| StackWithTextChildren | mount | 5676 | 5700 | 5000 | |
| SwatchColorPicker | mount | 13059 | 12041 | 5000 | |
| TagPicker | mount | 2778 | 2781 | 5000 | |
| TeachingBubble | mount | 84398 | 84358 | 5000 | |
| Text | mount | 451 | 462 | 5000 | |
| TextField | mount | 1446 | 1474 | 5000 | |
| ThemeProvider | mount | 1226 | 1204 | 5000 | |
| ThemeProvider | virtual-rerender | 650 | 677 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1796 | 1834 | 5000 | |
| Toggle | mount | 834 | 842 | 5000 | |
| buttonNative | mount | 130 | 127 | 5000 |
behowell
approved these changes
Jul 25, 2022
| <div | ||
| class="fui-DialogSurface" | ||
| data-tabster="{\\"deloser\\":{},\\"modalizer\\":{\\"id\\":\\"modal-9\\",\\"isOthersAccessible\\":false}}" | ||
| data-tabster="{\\"deloser\\":{},\\"modalizer\\":{\\"id\\":\\"modal-8\\",\\"isOthersAccessible\\":false}}" |
Contributor
There was a problem hiding this comment.
Why did this change? (It doesn't appear to be anything to worry about... but I wouldn't expect any snapshots to change from this PR)
Contributor
There was a problem hiding this comment.
Answering my own question: It appears that it happened because DialogSurface.test.tsx doesn't reset test IDs after each test. Even though DialogSurface had disabled one of the conformance tests you're removing, it didn't disable the other, so there's still net one fewer test being run, which was presumably using a generated ID somewhere.
Contributor
There was a problem hiding this comment.
Thx for the heads up. I'll address that!
layershifter
approved these changes
Jul 26, 2022
spmonahan
approved these changes
Jul 26, 2022
GeoffCoxMSFT
approved these changes
Jul 26, 2022
micahgodbolt
approved these changes
Jul 26, 2022
khmakoto
approved these changes
Jul 27, 2022
sopranopillow
approved these changes
Jul 27, 2022
Hotell
approved these changes
Jul 27, 2022
Hotell
left a comment
Hotell
left a comment
Contributor
There was a problem hiding this comment.
all good for cxe-prg packages
| }); | ||
| }, | ||
|
|
||
| /** Component file has assigned and exported static class */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #23494, i.e, it removes the deprecated conformance tests for exporting static classnames now that we have switched to a classNames object. Since this is a big PR and modifies pretty much all the converged components, to help with review I ask that you look at the component(s) that you have worked on and make sure that the change looks good.