Component Template: Remove className export#24045
Merged
behowell merged 3 commits intoJul 28, 2022
Merged
Conversation
sopranopillow
approved these changes
Jul 22, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5695e51:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2d157ff271bddd250ea34d4c8c1ef8220d1a83cc (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1337 | 1339 | 5000 | |
| Button | mount | 930 | 940 | 5000 | |
| FluentProvider | mount | 1640 | 1614 | 5000 | |
| FluentProviderWithTheme | mount | 643 | 649 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 587 | 594 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 639 | 611 | 10 | |
| MakeStyles | mount | 1934 | 1968 | 50000 | |
| SpinButton | mount | 2681 | 2689 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ChatDuplicateMessagesPerf.default | 236 | 217 | 1.09:1 |
| AttachmentSlotsPerf.default | 876 | 838 | 1.05:1 |
| LabelMinimalPerf.default | 347 | 331 | 1.05:1 |
| DividerMinimalPerf.default | 321 | 310 | 1.04:1 |
| FormMinimalPerf.default | 365 | 351 | 1.04:1 |
| ListWith60ListItems.default | 522 | 501 | 1.04:1 |
| TextAreaMinimalPerf.default | 442 | 425 | 1.04:1 |
| AttachmentMinimalPerf.default | 129 | 125 | 1.03:1 |
| GridMinimalPerf.default | 293 | 285 | 1.03:1 |
| ListMinimalPerf.default | 468 | 454 | 1.03:1 |
| TextMinimalPerf.default | 314 | 305 | 1.03:1 |
| AnimationMinimalPerf.default | 493 | 485 | 1.02:1 |
| ImageMinimalPerf.default | 332 | 324 | 1.02:1 |
| LayoutMinimalPerf.default | 316 | 309 | 1.02:1 |
| RadioGroupMinimalPerf.default | 406 | 398 | 1.02:1 |
| SliderMinimalPerf.default | 1342 | 1317 | 1.02:1 |
| IconMinimalPerf.default | 541 | 531 | 1.02:1 |
| TableMinimalPerf.default | 366 | 360 | 1.02:1 |
| TreeMinimalPerf.default | 710 | 698 | 1.02:1 |
| VideoMinimalPerf.default | 573 | 563 | 1.02:1 |
| AvatarMinimalPerf.default | 160 | 159 | 1.01:1 |
| CarouselMinimalPerf.default | 360 | 357 | 1.01:1 |
| ChatWithPopoverPerf.default | 313 | 309 | 1.01:1 |
| DialogMinimalPerf.default | 696 | 691 | 1.01:1 |
| DropdownMinimalPerf.default | 2600 | 2568 | 1.01:1 |
| InputMinimalPerf.default | 993 | 987 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 997 | 990 | 1.01:1 |
| RosterPerf.default | 845 | 833 | 1.01:1 |
| PopupMinimalPerf.default | 555 | 548 | 1.01:1 |
| PortalMinimalPerf.default | 145 | 143 | 1.01:1 |
| ProviderMergeThemesPerf.default | 997 | 990 | 1.01:1 |
| ProviderMinimalPerf.default | 319 | 316 | 1.01:1 |
| ReactionMinimalPerf.default | 330 | 326 | 1.01:1 |
| SegmentMinimalPerf.default | 314 | 312 | 1.01:1 |
| ToolbarMinimalPerf.default | 836 | 829 | 1.01:1 |
| BoxMinimalPerf.default | 298 | 297 | 1:1 |
| ButtonSlotsPerf.default | 419 | 418 | 1:1 |
| CardMinimalPerf.default | 496 | 497 | 1:1 |
| ChatMinimalPerf.default | 658 | 659 | 1:1 |
| CheckboxMinimalPerf.default | 1958 | 1956 | 1:1 |
| DatepickerMinimalPerf.default | 4703 | 4680 | 1:1 |
| DropdownManyItemsPerf.default | 556 | 556 | 1:1 |
| EmbedMinimalPerf.default | 2997 | 2998 | 1:1 |
| ListNestedPerf.default | 471 | 472 | 1:1 |
| MenuMinimalPerf.default | 754 | 752 | 1:1 |
| MenuButtonMinimalPerf.default | 1362 | 1360 | 1:1 |
| RefMinimalPerf.default | 202 | 201 | 1:1 |
| SkeletonMinimalPerf.default | 308 | 307 | 1:1 |
| SplitButtonMinimalPerf.default | 3319 | 3319 | 1:1 |
| TableManyItemsPerf.default | 1617 | 1611 | 1:1 |
| CustomToolbarPrototype.default | 2197 | 2203 | 1:1 |
| TooltipMinimalPerf.default | 962 | 965 | 1:1 |
| ButtonMinimalPerf.default | 138 | 140 | 0.99:1 |
| FlexMinimalPerf.default | 247 | 250 | 0.99:1 |
| HeaderMinimalPerf.default | 319 | 323 | 0.99:1 |
| HeaderSlotsPerf.default | 678 | 686 | 0.99:1 |
| ListCommonPerf.default | 515 | 520 | 0.99:1 |
| StatusMinimalPerf.default | 607 | 613 | 0.99:1 |
| AlertMinimalPerf.default | 225 | 230 | 0.98:1 |
| ButtonOverridesMissPerf.default | 1149 | 1168 | 0.98:1 |
| LoaderMinimalPerf.default | 526 | 536 | 0.98:1 |
| TreeWith60ListItems.default | 127 | 129 | 0.98:1 |
| AccordionMinimalPerf.default | 124 | 129 | 0.96:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 801 | 801 | 5000 | |
| Breadcrumb | mount | 2344 | 2367 | 1000 | |
| Checkbox | mount | 2239 | 2250 | 5000 | |
| CheckboxBase | mount | 1950 | 1961 | 5000 | |
| ChoiceGroup | mount | 4077 | 4038 | 5000 | |
| ComboBox | mount | 825 | 861 | 1000 | |
| CommandBar | mount | 9227 | 9173 | 1000 | |
| ContextualMenu | mount | 10437 | 10437 | 1000 | |
| DefaultButton | mount | 1012 | 1012 | 5000 | |
| DetailsRow | mount | 3310 | 3351 | 5000 | |
| DetailsRowFast | mount | 3340 | 3302 | 5000 | |
| DetailsRowNoStyles | mount | 3210 | 3098 | 5000 | |
| Dialog | mount | 2462 | 2446 | 1000 | |
| DocumentCardTitle | mount | 147 | 156 | 1000 | |
| Dropdown | mount | 2887 | 2899 | 5000 | |
| FocusTrapZone | mount | 1651 | 1633 | 5000 | |
| FocusZone | mount | 1550 | 1604 | 5000 | |
| IconButton | mount | 1530 | 1509 | 5000 | |
| Label | mount | 295 | 301 | 5000 | |
| Layer | mount | 2690 | 2689 | 5000 | |
| Link | mount | 402 | 410 | 5000 | |
| MenuButton | mount | 1275 | 1272 | 5000 | |
| MessageBar | mount | 1907 | 1817 | 5000 | |
| Nav | mount | 2839 | 2879 | 1000 | |
| OverflowSet | mount | 951 | 945 | 5000 | |
| Panel | mount | 1922 | 1877 | 1000 | |
| Persona | mount | 870 | 875 | 1000 | |
| Pivot | mount | 1241 | 1271 | 1000 | |
| PrimaryButton | mount | 1128 | 1117 | 5000 | |
| Rating | mount | 6615 | 6681 | 5000 | |
| SearchBox | mount | 1143 | 1129 | 5000 | |
| Shimmer | mount | 2188 | 2170 | 5000 | |
| Slider | mount | 1668 | 1672 | 5000 | |
| SpinButton | mount | 4427 | 4371 | 5000 | |
| Spinner | mount | 370 | 377 | 5000 | |
| SplitButton | mount | 2782 | 2772 | 5000 | |
| Stack | mount | 463 | 446 | 5000 | |
| StackWithIntrinsicChildren | mount | 1919 | 1971 | 5000 | |
| StackWithTextChildren | mount | 4507 | 4497 | 5000 | |
| SwatchColorPicker | mount | 10110 | 10185 | 5000 | |
| TagPicker | mount | 2312 | 2318 | 5000 | |
| TeachingBubble | mount | 84948 | 86793 | 5000 | |
| Text | mount | 380 | 370 | 5000 | |
| TextField | mount | 1199 | 1230 | 5000 | |
| ThemeProvider | mount | 1035 | 1034 | 5000 | |
| ThemeProvider | virtual-rerender | 580 | 587 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1565 | 1543 | 5000 | |
| Toggle | mount | 712 | 715 | 5000 | |
| buttonNative | mount | 114 | 111 | 5000 |
khmakoto
approved these changes
Jul 22, 2022
spmonahan
approved these changes
Jul 22, 2022
spmonahan
left a comment
spmonahan
left a comment
Contributor
There was a problem hiding this comment.
Change looks good but something really blew up on Northstar's Screener setup
ling1726
reviewed
Jul 25, 2022
| import type { SlotClassNames } from '@fluentui/react-utilities'; | ||
|
|
||
|
|
||
| export const {{componentNames.propertyName}}ClassName = 'fui-{{componentName}}' |
Contributor
There was a problem hiding this comment.
You should update the conformance tests so that this does not fail for folks creating new packages
Contributor
There was a problem hiding this comment.
@tomi-msft just picked up the issue to remove the tests 😁
Contributor
Author
There was a problem hiding this comment.
I'll wait for @tomi-msft's PR to be merged before merging this one:
Contributor
Author
There was a problem hiding this comment.
@ling1726 The PR to remove the test is now merged
ling1726
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
{{component}}ClassNameexport was removed from all components, but still exists in the template.New Behavior
Components created with the template will no longer export the single
{{component}}ClassNameRelated Issue(s)
The export was removed from all existing components by this issue and PR:
<componentName>ClassNameexports #22132<componentName>ClassNameexports from v9 packages #23026