chore: Update Griffel to latest version#25212
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1bfae61:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5280dfeda349453f42b51ae49c9d128bc322c609 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1313 | 1306 | 5000 | |
| Button | mount | 951 | 870 | 5000 | |
| FluentProvider | mount | 1589 | 1559 | 5000 | |
| FluentProviderWithTheme | mount | 627 | 562 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 595 | 581 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 621 | 637 | 10 | |
| MakeStyles | mount | 1927 | 1892 | 50000 | |
| SpinButton | mount | 2415 | 2359 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AlertMinimalPerf.default | 234 | 220 | 1.06:1 |
| ChatDuplicateMessagesPerf.default | 219 | 207 | 1.06:1 |
| AttachmentMinimalPerf.default | 132 | 126 | 1.05:1 |
| FormMinimalPerf.default | 337 | 322 | 1.05:1 |
| HeaderMinimalPerf.default | 328 | 311 | 1.05:1 |
| DividerMinimalPerf.default | 321 | 310 | 1.04:1 |
| ImageMinimalPerf.default | 352 | 339 | 1.04:1 |
| DropdownManyItemsPerf.default | 550 | 532 | 1.03:1 |
| FlexMinimalPerf.default | 252 | 245 | 1.03:1 |
| TextMinimalPerf.default | 308 | 298 | 1.03:1 |
| AvatarMinimalPerf.default | 166 | 163 | 1.02:1 |
| ButtonSlotsPerf.default | 435 | 426 | 1.02:1 |
| ChatWithPopoverPerf.default | 294 | 289 | 1.02:1 |
| LabelMinimalPerf.default | 345 | 339 | 1.02:1 |
| ListNestedPerf.default | 473 | 465 | 1.02:1 |
| PortalMinimalPerf.default | 142 | 139 | 1.02:1 |
| ReactionMinimalPerf.default | 335 | 330 | 1.02:1 |
| AnimationMinimalPerf.default | 476 | 469 | 1.01:1 |
| AttachmentSlotsPerf.default | 889 | 880 | 1.01:1 |
| CardMinimalPerf.default | 469 | 464 | 1.01:1 |
| CheckboxMinimalPerf.default | 1543 | 1534 | 1.01:1 |
| GridMinimalPerf.default | 300 | 296 | 1.01:1 |
| InputMinimalPerf.default | 851 | 845 | 1.01:1 |
| LoaderMinimalPerf.default | 519 | 515 | 1.01:1 |
| MenuMinimalPerf.default | 742 | 734 | 1.01:1 |
| SegmentMinimalPerf.default | 302 | 300 | 1.01:1 |
| IconMinimalPerf.default | 567 | 564 | 1.01:1 |
| ToolbarMinimalPerf.default | 808 | 797 | 1.01:1 |
| VideoMinimalPerf.default | 630 | 622 | 1.01:1 |
| CarouselMinimalPerf.default | 357 | 358 | 1:1 |
| ChatMinimalPerf.default | 644 | 643 | 1:1 |
| DialogMinimalPerf.default | 693 | 690 | 1:1 |
| DropdownMinimalPerf.default | 2172 | 2172 | 1:1 |
| EmbedMinimalPerf.default | 2643 | 2655 | 1:1 |
| ItemLayoutMinimalPerf.default | 978 | 978 | 1:1 |
| MenuButtonMinimalPerf.default | 1362 | 1361 | 1:1 |
| RosterPerf.default | 1702 | 1694 | 1:1 |
| ProviderMergeThemesPerf.default | 986 | 989 | 1:1 |
| SliderMinimalPerf.default | 1254 | 1250 | 1:1 |
| SplitButtonMinimalPerf.default | 3286 | 3273 | 1:1 |
| TableManyItemsPerf.default | 1578 | 1574 | 1:1 |
| TextAreaMinimalPerf.default | 413 | 412 | 1:1 |
| TreeMinimalPerf.default | 712 | 709 | 1:1 |
| BoxMinimalPerf.default | 297 | 299 | 0.99:1 |
| DatepickerMinimalPerf.default | 4669 | 4726 | 0.99:1 |
| HeaderSlotsPerf.default | 686 | 691 | 0.99:1 |
| LayoutMinimalPerf.default | 315 | 317 | 0.99:1 |
| ListMinimalPerf.default | 461 | 464 | 0.99:1 |
| ListWith60ListItems.default | 495 | 501 | 0.99:1 |
| PopupMinimalPerf.default | 550 | 555 | 0.99:1 |
| ProviderMinimalPerf.default | 313 | 315 | 0.99:1 |
| SkeletonMinimalPerf.default | 299 | 303 | 0.99:1 |
| StatusMinimalPerf.default | 604 | 612 | 0.99:1 |
| CustomToolbarPrototype.default | 2136 | 2149 | 0.99:1 |
| TooltipMinimalPerf.default | 1857 | 1872 | 0.99:1 |
| ButtonMinimalPerf.default | 134 | 137 | 0.98:1 |
| ButtonOverridesMissPerf.default | 1012 | 1029 | 0.98:1 |
| ListCommonPerf.default | 523 | 533 | 0.98:1 |
| RadioGroupMinimalPerf.default | 384 | 391 | 0.98:1 |
| TableMinimalPerf.default | 352 | 358 | 0.98:1 |
| AccordionMinimalPerf.default | 121 | 125 | 0.97:1 |
| RefMinimalPerf.default | 177 | 186 | 0.95:1 |
| TreeWith60ListItems.default | 124 | 132 | 0.94:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1174 | 1188 | 5000 | |
| Breadcrumb | mount | 2752 | 2757 | 1000 | |
| Checkbox | mount | 2623 | 2661 | 5000 | |
| CheckboxBase | mount | 2381 | 2356 | 5000 | |
| ChoiceGroup | mount | 4259 | 4167 | 5000 | |
| ComboBox | mount | 1185 | 1161 | 1000 | |
| CommandBar | mount | 9275 | 9220 | 1000 | |
| ContextualMenu | mount | 10223 | 10176 | 1000 | |
| DefaultButton | mount | 1348 | 1366 | 5000 | |
| DetailsRow | mount | 3391 | 3342 | 5000 | |
| DetailsRowFast | mount | 3399 | 3374 | 5000 | |
| DetailsRowNoStyles | mount | 3232 | 3228 | 5000 | |
| Dialog | mount | 3000 | 2939 | 1000 | |
| DocumentCardTitle | mount | 564 | 577 | 1000 | |
| Dropdown | mount | 3151 | 3114 | 5000 | |
| FocusTrapZone | mount | 1966 | 1945 | 5000 | |
| FocusZone | mount | 1909 | 1905 | 5000 | |
| GroupedList | mount | 48343 | 53277 | 2 | |
| GroupedList | virtual-rerender | 22965 | 22840 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 82895 | 82372 | 2 | |
| GroupedListV2 | mount | 559 | 565 | 2 | |
| GroupedListV2 | virtual-rerender | 532 | 518 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 557 | 557 | 2 | |
| IconButton | mount | 1775 | 1787 | 5000 | |
| Label | mount | 756 | 760 | 5000 | |
| Layer | mount | 4123 | 4096 | 5000 | |
| Link | mount | 847 | 858 | 5000 | |
| MenuButton | mount | 1618 | 1601 | 5000 | |
| MessageBar | mount | 2419 | 2358 | 5000 | |
| Nav | mount | 3054 | 3079 | 1000 | |
| OverflowSet | mount | 1422 | 1403 | 5000 | |
| Panel | mount | 2534 | 2498 | 1000 | |
| Persona | mount | 1244 | 1225 | 1000 | |
| Pivot | mount | 1522 | 1539 | 1000 | |
| PrimaryButton | mount | 1495 | 1498 | 5000 | |
| Rating | mount | 6986 | 6968 | 5000 | |
| SearchBox | mount | 1488 | 1494 | 5000 | |
| Shimmer | mount | 2923 | 2911 | 5000 | |
| Slider | mount | 2119 | 2123 | 5000 | |
| SpinButton | mount | 4252 | 4278 | 5000 | |
| Spinner | mount | 828 | 840 | 5000 | |
| SplitButton | mount | 2810 | 2857 | 5000 | |
| Stack | mount | 887 | 884 | 5000 | |
| StackWithIntrinsicChildren | mount | 2245 | 2267 | 5000 | |
| StackWithTextChildren | mount | 4948 | 4957 | 5000 | |
| SwatchColorPicker | mount | 9507 | 9515 | 5000 | |
| TagPicker | mount | 2316 | 2351 | 5000 | |
| TeachingBubble | mount | 76184 | 75846 | 5000 | |
| Text | mount | 821 | 814 | 5000 | |
| TextField | mount | 1531 | 1564 | 5000 | |
| ThemeProvider | mount | 1443 | 1429 | 5000 | |
| ThemeProvider | virtual-rerender | 1145 | 1146 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1992 | 2010 | 5000 | |
| Toggle | mount | 1123 | 1140 | 5000 | |
| buttonNative | mount | 526 | 538 | 5000 |
layershifter
force-pushed
the
chore/bump-griffel-3
branch
from
October 13, 2022 13:14
7adfae9 to
d84cadb
Compare
layershifter
marked this pull request as ready for review
October 13, 2022 13:28
layershifter
requested review from
a team,
GeoffCoxMSFT,
behowell,
chpalac,
khmakoto,
ling1726,
micahgodbolt,
smhigley,
sopranopillow,
spmonahan and
tomi-msft
as code owners
October 13, 2022 13:28
ling1726
approved these changes
Oct 13, 2022
spmonahan
approved these changes
Oct 13, 2022
TristanWatanabe
approved these changes
Oct 14, 2022
layershifter
force-pushed
the
chore/bump-griffel-3
branch
from
October 14, 2022 08:30
d84cadb to
1bfae61
Compare
sopranopillow
approved these changes
Oct 14, 2022
tudorpopams
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
Technically the support for
makeResetStyles(microsoft/griffel#225) came with the previous upgrade (#25075), but it didn't supportanimationName(microsoft/griffel#241) and support for build time transforms (microsoft/griffel#236).This upgrade brings them as the fix for
url()handling (microsoft/griffel#237) which is not used anywhere in Fluent UI itself.The main goal is to get fully functioning
makeResetStylesand try it to optimize existing components to reduce amount of atomic classes in base components.