feat: add support for animationName in makeResetStyles#241
Merged
Conversation
Contributor
📊 Bundle size reportUnchanged fixtures
|
layershifter
force-pushed
the
feat/mkrt-animations
branch
from
October 4, 2022 11:10
3e89921 to
2d98ccb
Compare
layershifter
commented
Oct 4, 2022
Comment on lines
+37
to
+53
| it('handles RTL', () => { | ||
| const computeClassName = makeResetStyles({ | ||
| padding: '40px 20px 10px 5px', | ||
| }); | ||
|
|
||
| expect(computeClassName({ dir: 'ltr', renderer })).toEqual('rfgb6zd6'); | ||
| expect(computeClassName({ dir: 'rtl', renderer })).toEqual('rfjhindo'); | ||
|
|
||
| expect(renderer).toMatchInlineSnapshot(` | ||
| .rfgb6zd6 { | ||
| padding: 40px 20px 10px 5px; | ||
| } | ||
| .rfjhindo { | ||
| padding: 40px 5px 10px 20px; | ||
| } | ||
| `); | ||
| }); |
Member
Author
There was a problem hiding this comment.
Add a new test to check classes.
layershifter
commented
Oct 4, 2022
Comment on lines
+4
to
+16
| expect.addSnapshotSerializer({ | ||
| test(value) { | ||
| return Array.isArray(value); | ||
| }, | ||
| print(value) { | ||
| /** | ||
| * test function makes sure that value is the guarded type | ||
| */ | ||
| const _value = value as ReturnType<typeof resolveResetStyleRules>; | ||
|
|
||
| return prettier.format(_value[2].join(''), { parser: 'css' }).trim(); | ||
| }, | ||
| }); |
Member
Author
There was a problem hiding this comment.
Added a serializer to make CSS output nicer (and readable actually).
layershifter
force-pushed
the
feat/mkrt-animations
branch
2 times, most recently
from
October 4, 2022 11:13
1dafe5d to
5b60b14
Compare
layershifter
force-pushed
the
feat/mkrt-animations
branch
from
October 4, 2022 11:21
5b60b14 to
3809ff4
Compare
layershifter
marked this pull request as ready for review
October 4, 2022 11:29
ling1726
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239. Follow up on #232.
makeResetStylesto handleanimationNamein the same way asmakeStyles. Implementation is close tomakeStylesresolveResetStyleRulesto make snapshots readable