Cherry-pick fix for wrong narration when legend selected#25936
Merged
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8c26b4e2c34095aa7fdbf3dee180b52b553833dd (build) |
Collaborator
Perf AnalysisNo significant results to display. All results
|
AtishayMsft
reviewed
Dec 14, 2022
| { | ||
| "type": "patch", | ||
| "comment": "Fix wrong narration when legend selected", | ||
| "packageName": "@uifabric/charting", |
Contributor
There was a problem hiding this comment.
From what I remember, doesn't this change depend on the change where you added active/highlighted legend states.
Contributor
Author
There was a problem hiding this comment.
Actually, it was the other way around. #24563 depended on this change
Collaborator
🕵 FluentUI-v7 No visual regressions between this PR and main |
AtishayMsft
approved these changes
Jan 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #24903 and #25978