Hide callout on legend hover#25978
Merged
Merged
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against 4b52fb0c1a42202c98ea350c9d9411a172b1120d |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4b52fb0c1a42202c98ea350c9d9411a172b1120d (build) |
AtishayMsft
reviewed
Dec 14, 2022
| @@ -477,6 +477,7 @@ export class AreaChartBase extends React.Component<IAreaChartProps, IAreaChartSt | |||
| }, | |||
| hoverAction: () => { | |||
| this._onLegendHover(singleChartData.legend); | |||
Contributor
There was a problem hiding this comment.
Should handleChartMouseLeave come first.
Contributor
Author
There was a problem hiding this comment.
I think this doesn't make much of a difference result-wise as setState is asynchronous. But it will surely be easier to understand if handleChartMouseLeave comes first
AtishayMsft
approved these changes
Dec 14, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 690e9e4:
|
2 tasks
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* hide callout on legend hover * add change file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The callout stays visible when user hovers over legends
New Behavior
The callout hides when user hovers over legends