chore(scripts-puppeteer): try closing open about:blank to free up memory#26461
Closed
Hotell wants to merge 1 commit into
Closed
chore(scripts-puppeteer): try closing open about:blank to free up memory#26461Hotell wants to merge 1 commit into
Hotell wants to merge 1 commit into
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8e9b5bf66f027b40ef7ccf5272940a343d330446 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d0be0d0:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 8e9b5bf66f027b40ef7ccf5272940a343d330446 |
Collaborator
Perf Analysis (
|
Hotell
force-pushed
the
hotell/build/scripts/puppeter-tweaks-2
branch
from
January 23, 2023 17:50
61a2d8b to
d0be0d0
Compare
Hotell
changed the title
Hotell
commented
Jan 23, 2023
|
|
||
| /** | ||
| * | ||
| * Try out https://github.com/puppeteer/puppeteer/issues/1490 |
Contributor
Author
There was a problem hiding this comment.
ok this won't fix anything , pipeline failed
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
Puppeteer page open timeout errors still continue. Added helper to try another thing that might help to improve the situation.
Related Issue(s)
launchandstartServerfunctions as single source of truth for creating new browser/server instance within monorepo #26375