Skip to content

chore(scripts-puppeteer): try closing open about:blank to free up memory #26461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hotell wants to merge 1 commit into from
+32 −6
Closed

chore(scripts-puppeteer): try closing open about:blank to free up memory #26461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/ssr-tests-v9/src/utils/visitPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { Browser } from 'puppeteer';
import { visitUrl } from '@fluentui/scripts-puppeteer';
import { closeUrl, visitUrl } from '@fluentui/scripts-puppeteer';
import { PROVIDER_ID } from './constants';

class RenderError extends Error {
Expand Down Expand Up @@ -37,7 +37,8 @@ export async function visitPage(browser: Browser, url: string) {
await visitUrl(page, url);

await page.waitForSelector(`#${PROVIDER_ID}`);
await page.close();

await closeUrl(browser, page);

if (error) {
throw error;
Expand Down
5 changes: 2 additions & 3 deletions scripts/projects-test/src/performBrowserTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Server } from 'http';
import { AddressInfo } from 'net';

import { launch, visitUrl } from '@fluentui/scripts-puppeteer';
import { closeUrl, launch, visitUrl } from '@fluentui/scripts-puppeteer';
import express, { Express } from 'express';

/**
Expand Down Expand Up @@ -99,8 +99,7 @@ export async function performBrowserTest(publicDirectory: string) {
});

await visitUrl(page, url);

await page.close();
await closeUrl(browser, page);
await browser.close();
await closeServer(server);

Expand Down
2 changes: 1 addition & 1 deletion scripts/puppeteer/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { launch, visitUrl } from './utils';
export { launch, visitUrl, closeUrl } from './utils';
26 changes: 26 additions & 0 deletions scripts/puppeteer/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,32 @@ export async function launch(options: LaunchOptions = {}) {
return browser;
}

/**
*
* Try out https://github.com/puppeteer/puppeteer/issues/1490

@Hotell Hotell Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this won't fix anything , pipeline failed
image

*/
export async function closeUrl(browser: puppeteer.Browser, page: puppeteer.Page) {
await page.close();

const pages = await browser.pages();
console.log(
'puppeteer: existing open pages',
pages.map(_page => _page.url()),
);

for (const browserPage of pages) {
if (browserPage.isClosed()) {
continue;
}

const url = browserPage.url();
if (url === 'about:blank') {
console.log('puppeteer: closing about:blank page');
await browserPage.close();
}
}
}

export async function visitUrl(page: puppeteer.Page, url: string) {
const TEN_SECONDS = 10 * 1000;
const maxAttempts = 5;
Expand Down