Skip to content

feat: Implement Toast pause#27811

Merged
ling1726 merged 5 commits into
microsoft:masterfrom
ling1726:react-toast/feat/pause-toast
May 11, 2023
Merged

feat: Implement Toast pause#27811
ling1726 merged 5 commits into
microsoft:masterfrom
ling1726:react-toast/feat/pause-toast

Conversation

@ling1726

Copy link
Copy Markdown
Contributor

Implements two new options:

  • pauseOnWindowBlur - pauses toast timeout when window is not focused
  • pauseOnHover - pauses toast when cursor enters the toast surface

Addresses #27776

Implements two new options:

* pauseOnWindowBlur - pauses toast timeout when window is not focused
* pauseOnHover - pauses toast when cursor enters the toast surface
@ling1726
ling1726 marked this pull request as ready for review May 10, 2023 15:40
@ling1726
ling1726 requested a review from a team as a code owner May 10, 2023 15:40
@fabricteam

fabricteam commented May 10, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 88ff00c2979ecd025f725fa3fc4e4d370f95cfc4

@codesandbox-ci

codesandbox-ci Bot commented May 10, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 767014b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented May 10, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 381cc2d5b1bd6032428bcc506501b2a591825c4a (build)

@github-actions github-actions Bot added this to the May Project Cycle Q2 2023 milestone May 11, 2023
Comment thread packages/react-components/react-toast/src/state/vanilla/toast.ts Outdated
Comment thread packages/react-components/react-toast/src/state/vanilla/toast.ts
Comment thread packages/react-components/react-toast/src/components/Toast.tsx Outdated
Comment thread packages/react-components/react-toast/src/components/Toast.tsx Outdated
Comment thread packages/react-components/react-toast/src/state/useToast.ts
Comment thread packages/react-components/react-toast/src/state/useToast.ts Outdated
Comment thread packages/react-components/react-toast/src/state/types.ts
@ling1726
ling1726 merged commit 0355d95 into microsoft:master May 11, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 12, 2023
* feat/drawer-header:
  feat: Update existing toasts (microsoft#27827)
  bugfix: fix horizontal overflow on tree (microsoft#27825)
  feat: Allow toast options to be configured from the toaster (microsoft#27820)
  feat: creates TreeItemAside component (microsoft#27701)
  fix: generate API
  fix: use composition to build DrawerHeaderTitle
  Virtualizer: Dynamic scroll view and optimizations (microsoft#27298)
  bugfix(react-dialog): change DialogTitle default action icon size (microsoft#27815)
  feat: Implement Toast pause (microsoft#27811)
  fix: ToolbarToggleButton should not follow Toolbar size (microsoft#27797)
  feat: defers useControllableState state to initializer method (microsoft#27717)
  feat: Implement toast dismiss (microsoft#27810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants