Skip to content

feat: Allow toast options to be configured from the toaster#27820

Merged
ling1726 merged 3 commits into
microsoft:masterfrom
ling1726:react-toast/feat/default-toast-options
May 12, 2023
Merged

feat: Allow toast options to be configured from the toaster#27820
ling1726 merged 3 commits into
microsoft:masterfrom
ling1726:react-toast/feat/default-toast-options

Conversation

@ling1726

Copy link
Copy Markdown
Contributor

Allows toaster to set default options for toasts

Addresses #27776

Allows toaster to set default options for toasts
@github-actions github-actions Bot added this to the May Project Cycle Q2 2023 milestone May 11, 2023
@ling1726
ling1726 marked this pull request as ready for review May 11, 2023 20:21
@ling1726
ling1726 requested a review from a team as a code owner May 11, 2023 20:21
@fabricteam

fabricteam commented May 11, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against e741b289a0cda2711146d171d3b08deb8bb7a156

@codesandbox-ci

codesandbox-ci Bot commented May 11, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d5b1234:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented May 11, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e741b289a0cda2711146d171d3b08deb8bb7a156 (build)

Comment thread packages/react-components/react-toast/src/components/Toaster.tsx Outdated
Comment thread packages/react-components/react-toast/src/state/useToaster.ts
Comment thread packages/react-components/react-toast/src/state/useToaster.ts Outdated
Comment thread packages/react-components/react-toast/src/state/vanilla/toaster.ts Outdated
@ling1726
ling1726 requested a review from layershifter May 12, 2023 12:43
Comment thread packages/react-components/react-toast/src/state/useToaster.ts
Comment thread packages/react-components/react-toast/src/state/vanilla/dispatchToast.ts Outdated
@ling1726
ling1726 enabled auto-merge (squash) May 12, 2023 13:07
@ling1726
ling1726 merged commit 4b272c2 into microsoft:master May 12, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 12, 2023
* feat/drawer-header:
  feat: Update existing toasts (microsoft#27827)
  bugfix: fix horizontal overflow on tree (microsoft#27825)
  feat: Allow toast options to be configured from the toaster (microsoft#27820)
  feat: creates TreeItemAside component (microsoft#27701)
  fix: generate API
  fix: use composition to build DrawerHeaderTitle
  Virtualizer: Dynamic scroll view and optimizations (microsoft#27298)
  bugfix(react-dialog): change DialogTitle default action icon size (microsoft#27815)
  feat: Implement Toast pause (microsoft#27811)
  fix: ToolbarToggleButton should not follow Toolbar size (microsoft#27797)
  feat: defers useControllableState state to initializer method (microsoft#27717)
  feat: Implement toast dismiss (microsoft#27810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants