fix: Pivot overflow role uses tab#28409
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f2001b0:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
📊 Bundle size report🤖 This report was generated against e4ef333f187d19408a2445aee5c904bd584d21ef |
Asset size changes
Baseline commit: e4ef333f187d19408a2445aee5c904bd584d21ef (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 635 | 635 | 5000 | |
| Breadcrumb | mount | 1699 | 1688 | 1000 | |
| Checkbox | mount | 1674 | 1695 | 5000 | |
| CheckboxBase | mount | 1498 | 1458 | 5000 | |
| ChoiceGroup | mount | 2993 | 2893 | 5000 | |
| ComboBox | mount | 671 | 672 | 1000 | |
| CommandBar | mount | 6151 | 6230 | 1000 | |
| ContextualMenu | mount | 11259 | 11999 | 1000 | |
| DefaultButton | mount | 737 | 737 | 5000 | |
| DetailsRow | mount | 2178 | 2151 | 5000 | |
| DetailsRowFast | mount | 2126 | 2165 | 5000 | |
| DetailsRowNoStyles | mount | 1989 | 1963 | 5000 | |
| Dialog | mount | 2663 | 2631 | 1000 | |
| DocumentCardTitle | mount | 219 | 231 | 1000 | |
| Dropdown | mount | 1982 | 1959 | 5000 | |
| FocusTrapZone | mount | 1136 | 1135 | 5000 | |
| FocusZone | mount | 1074 | 1043 | 5000 | |
| GroupedList | mount | 40902 | 40828 | 2 | |
| GroupedList | virtual-rerender | 19809 | 19829 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50605 | 50686 | 2 | |
| GroupedListV2 | mount | 227 | 242 | 2 | |
| GroupedListV2 | virtual-rerender | 210 | 211 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 226 | 235 | 2 | |
| IconButton | mount | 1069 | 1095 | 5000 | |
| Label | mount | 326 | 340 | 5000 | |
| Layer | mount | 2731 | 2724 | 5000 | |
| Link | mount | 398 | 385 | 5000 | |
| MenuButton | mount | 932 | 932 | 5000 | |
| MessageBar | mount | 21603 | 21538 | 5000 | |
| Nav | mount | 1914 | 1929 | 1000 | |
| OverflowSet | mount | 805 | 768 | 5000 | |
| Panel | mount | 1771 | 1757 | 1000 | |
| Persona | mount | 742 | 776 | 1000 | |
| Pivot | mount | 870 | 871 | 1000 | |
| PrimaryButton | mount | 866 | 848 | 5000 | |
| Rating | mount | 4623 | 4544 | 5000 | |
| SearchBox | mount | 897 | 913 | 5000 | |
| Shimmer | mount | 1860 | 1904 | 5000 | |
| Slider | mount | 1330 | 1315 | 5000 | |
| SpinButton | mount | 2914 | 2856 | 5000 | |
| Spinner | mount | 390 | 387 | 5000 | |
| SplitButton | mount | 1787 | 1859 | 5000 | |
| Stack | mount | 413 | 415 | 5000 | |
| StackWithIntrinsicChildren | mount | 874 | 848 | 5000 | |
| StackWithTextChildren | mount | 2702 | 2649 | 5000 | |
| SwatchColorPicker | mount | 6016 | 6141 | 5000 | |
| TagPicker | mount | 1452 | 1415 | 5000 | |
| Text | mount | 378 | 371 | 5000 | |
| TextField | mount | 967 | 931 | 5000 | |
| ThemeProvider | mount | 821 | 828 | 5000 | |
| ThemeProvider | virtual-rerender | 600 | 591 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1266 | 1298 | 5000 | |
| Toggle | mount | 610 | 600 | 5000 | |
| buttonNative | mount | 191 | 194 | 5000 |
micahgodbolt
approved these changes
Jul 14, 2023
sopranopillow
approved these changes
Jul 14, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 18, 2023
* master: ci(bundlesize): opt out using --since as lightrail doesnt support this behaviour and needs everything build on every PR (microsoft#28545) feat: automatically add v9 package stories to public docsite and correctly create codesandbox demo source code (microsoft#28528) applying package updates Keytips: Align keytipData with visible instance for dupes (microsoft#28522) applying package updates V8 Fluent2 Theme: Spinner sizes (microsoft#28512) feat: add extra-tiny size value to size prop (microsoft#28249) feat(react-infobutton): Remove InfoIcon from react-infobutton (microsoft#28534) Made Breadcrumb package public (microsoft#28549) X bars showing incorrect data when the values are large- bug 8380 (microsoft#28510) feat(tools): implement `prepare-initial-release` generator (microsoft#28505) feat: release react-breadcrumb to preview (microsoft#28402) applying package updates fix: v8 SplitButton and split MenuItem have two touch targets when checkable (microsoft#28523) fix(react-infobutton): Apply aria-owns only when the popover is open and cleanup infobutton stories (microsoft#28463) fix: Pivot overflow role uses tab (microsoft#28409) Migrate react-search to preview (microsoft#28531)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We were exposing the overflow button as a menu button rather than a tab. The pros and cons of each approach are pretty even -- in functionality it's a menubutton, but it's more expected to encounter a tab within a tablist. The reason for this change is that a menubutton within a tablist triggers an automated error, and a tab does not, and also likely does not have meaningful known user-facing drawbacks. This will also match the semantics used in v9's TabList.
New Behavior
The overflow button uses the tab role.
Related Issue(s)