feat: add extra-tiny size value to size prop#28249
Merged
Merged
Conversation
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changes
Baseline commit: bffeca38807f5cd9230e6dbbc4ef1be1766e29d5 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 618 | 642 | 5000 | |
| Button | mount | 285 | 295 | 5000 | |
| Field | mount | 1023 | 1069 | 5000 | |
| FluentProvider | mount | 646 | 644 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 66 | 68 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 78 | 10 | |
| InfoButton | mount | 13 | 13 | 5000 | |
| MakeStyles | mount | 859 | 856 | 50000 | |
| Persona | mount | 1663 | 1615 | 5000 | |
| SpinButton | mount | 1264 | 1271 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dad90d2:
|
khmakoto
reviewed
Jun 26, 2023
khmakoto
left a comment
khmakoto
left a comment
Member
There was a problem hiding this comment.
Should you add a vr test for an extra-tiny Spinner as well?
fabricteam
reviewed
Jun 26, 2023
github-actions
Bot
modified the milestones:
June Project Cycle Q2 2023,
July Project Cycle Q3 2023
khmakoto
approved these changes
Jul 5, 2023
behowell
reviewed
Jul 6, 2023
tomi-msft
requested review from
a team,
micahgodbolt,
robtaft-ms and
spmonahan
as code owners
July 11, 2023 20:33
…eact-spinner-context
fabricteam
reviewed
Jul 12, 2023
marcosmoura
approved these changes
Jul 13, 2023
marcosmoura
left a comment
marcosmoura
left a comment
Contributor
There was a problem hiding this comment.
Approved for files owned by @microsoft/cxe-prg
ling1726
removed request for
a team,
GeoffCoxMSFT,
Jacqueline-ms,
micahgodbolt,
ms-acalzaretto,
robtaft-ms and
spmonahan
July 14, 2023 11:57
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 18, 2023
* master: ci(bundlesize): opt out using --since as lightrail doesnt support this behaviour and needs everything build on every PR (microsoft#28545) feat: automatically add v9 package stories to public docsite and correctly create codesandbox demo source code (microsoft#28528) applying package updates Keytips: Align keytipData with visible instance for dupes (microsoft#28522) applying package updates V8 Fluent2 Theme: Spinner sizes (microsoft#28512) feat: add extra-tiny size value to size prop (microsoft#28249) feat(react-infobutton): Remove InfoIcon from react-infobutton (microsoft#28534) Made Breadcrumb package public (microsoft#28549) X bars showing incorrect data when the values are large- bug 8380 (microsoft#28510) feat(tools): implement `prepare-initial-release` generator (microsoft#28505) feat: release react-breadcrumb to preview (microsoft#28402) applying package updates fix: v8 SplitButton and split MenuItem have two touch targets when checkable (microsoft#28523) fix(react-infobutton): Apply aria-owns only when the popover is open and cleanup infobutton stories (microsoft#28463) fix: Pivot overflow role uses tab (microsoft#28409) Migrate react-search to preview (microsoft#28531)
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
extra-tinysize value to thesizeprop ofSpinner. It also adds a context toSpinner. Fixes #28223