Docs(react-tree): Update stories and remove third-party API calls #28757
Merged
Conversation
petdud
marked this pull request as ready for review
August 7, 2023 11:48
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 66 | 68 | 10 | Possible regression |
| InfoButton | mount | 12 | 13 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 649 | 646 | 5000 | |
| Button | mount | 312 | 311 | 5000 | |
| Field | mount | 1147 | 1154 | 5000 | |
| FluentProvider | mount | 675 | 686 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 66 | 68 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 79 | 10 | |
| InfoButton | mount | 12 | 13 | 5000 | Possible regression |
| MakeStyles | mount | 858 | 850 | 50000 | |
| Persona | mount | 1834 | 1766 | 5000 | |
| SpinButton | mount | 1445 | 1397 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 38d52d6:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d5ece238df797e84a59affc6162b0fa5cc46649d (build) |
bsunderhus
approved these changes
Aug 7, 2023
bsunderhus
added a commit
to bsunderhus/fluentui
that referenced
this pull request
Aug 8, 2023
bsunderhus
added a commit
that referenced
this pull request
Aug 10, 2023
…ufixes (#28776) * chore: update stories according to #28757 * chore: updates documentation * chore: properly labels stories and adds has actions * bugfix: aria-checked should be mixed when selection is mixed * bugfix: aria-selected is required * chore: adds best practices to aria-selected=true * bugfix: stop scrolling on Home and End * chore: updates stories with ARIALive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
This PR:
Related Issue(s)