Skip to content

[Chore]: publish @fluentui/react-tree-preview on public docsite + bufixes#28776

Merged
bsunderhus merged 8 commits into
microsoft:masterfrom
bsunderhus:react-tree-preview/chore--update-stories
Aug 10, 2023
Merged

[Chore]: publish @fluentui/react-tree-preview on public docsite + bufixes#28776
bsunderhus merged 8 commits into
microsoft:masterfrom
bsunderhus:react-tree-preview/chore--update-stories

Conversation

@bsunderhus

@bsunderhus bsunderhus commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

New Behavior

  1. updates stories according to Docs(react-tree): Update stories and remove third-party API calls  #28757
  2. updates stories with more detailed documentation
  3. Adds @fluentui/react-tree-preview to public docsite
  4. fix: aria-checked value to include mixed state
  5. fix: aria-selected is a required attribute https://www.w3.org/TR/wai-aria-1.1/#treeitem
  6. fix: stops scrolling when pressing Home and End

@bsunderhus bsunderhus self-assigned this Aug 8, 2023
@github-actions github-actions Bot added this to the August Project Cycle Q4 2023 milestone Aug 8, 2023
@bsunderhus
bsunderhus marked this pull request as ready for review August 8, 2023 11:21
@bsunderhus
bsunderhus requested a review from a team as a code owner August 8, 2023 11:21
@fabricteam

fabricteam commented Aug 8, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against c736e39f1e07e013cc4a700eaa6cdcd6ae02127c

@codesandbox-ci

codesandbox-ci Bot commented Aug 8, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3a49554:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Aug 8, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c736e39f1e07e013cc4a700eaa6cdcd6ae02127c (build)

Comment thread packages/react-components/react-tree-preview/stories/Tree/TreeActions.stories.tsx Outdated
@bsunderhus
bsunderhus requested review from a team as code owners August 9, 2023 09:53
@bsunderhus
bsunderhus requested a review from ling1726 August 9, 2023 09:53
@bsunderhus
bsunderhus force-pushed the react-tree-preview/chore--update-stories branch 3 times, most recently from d318c89 to 3beeb53 Compare August 9, 2023 12:57
@layershifter

Copy link
Copy Markdown
Member
  1. updates stories according to Docs(react-tree): Update stories and remove third-party API calls  #28757

@bsunderhus not sure that I understand what you meant.

@bsunderhus

bsunderhus commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author
  1. updates stories according to Docs(react-tree): Update stories and remove third-party API calls  #28757

@bsunderhus not sure that I understand what you meant.

So, now we got 2 packages, react-tree and react-tree-preview (yeah, it sucks). this PR basically copy pastes the content from one package into another

Comment thread packages/react-components/react-tree-preview/stories/Tree/TreeActions.stories.tsx Outdated
@bsunderhus
bsunderhus force-pushed the react-tree-preview/chore--update-stories branch from 3beeb53 to 74621a8 Compare August 9, 2023 13:39
@bsunderhus bsunderhus changed the title chore: update stories according to #28757 [Chore]: publish @fluentui/react-tree-preview on public docsite + bufixes Aug 10, 2023
@fabricteam

fabricteam commented Aug 10, 2023

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus
bsunderhus force-pushed the react-tree-preview/chore--update-stories branch 2 times, most recently from 7099d94 to 32560f6 Compare August 10, 2023 16:19
@bsunderhus
bsunderhus force-pushed the react-tree-preview/chore--update-stories branch from 32560f6 to 3a49554 Compare August 10, 2023 17:19
@bsunderhus
bsunderhus enabled auto-merge (squash) August 10, 2023 17:19
@bsunderhus
bsunderhus merged commit b944871 into microsoft:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants