chore: pin @swc/helper in codesandbox as it does not support dependency alias by YuanboXue-Amber · Pull Request #28918 · microsoft/fluentui

YuanboXue-Amber · 2023-08-21T10:11:28Z

In @fluentui/react-components we have '@swc/helpers': '^0.4.14', which resolves to 0.4.36. But @swc/helpers@0.4.36 uses dependency alias which is not supported by codesandbox. Therefore this PR pin it to 0.4.35 to make codesandbox working.

@swc/helpers@0.4.36 package.json:

Error in exported codesandbox:

// TODO
related codesandbox issue codesandbox/codesandbox-client#7975
related swc issue swc-project/swc#7843
fluent issue to upgrade @swc/helpers to 0.5.x: #28919

fabricteam · 2023-08-21T10:20:52Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	602	613	5000
Button	mount	315	333	5000
Field	mount	1091	1119	5000
FluentProvider	mount	677	686	5000
FluentProviderWithTheme	mount	85	84	10
FluentProviderWithTheme	virtual-rerender	73	70	10
FluentProviderWithTheme	virtual-rerender-with-unmount	69	78	10
InfoButton	mount	9	14	5000
MakeStyles	mount	875	876	50000
Persona	mount	1727	1660	5000
SpinButton	mount	1415	1348	5000

fabricteam · 2023-08-21T10:23:44Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	101	89	1.13:1
IconMinimalPerf.default	427	378	1.13:1
RefMinimalPerf.default	110	103	1.07:1
ChatDuplicateMessagesPerf.default	150	142	1.06:1
ListNestedPerf.default	324	306	1.06:1
SegmentMinimalPerf.default	203	191	1.06:1
AccordionMinimalPerf.default	78	74	1.05:1
AlertMinimalPerf.default	165	157	1.05:1
GridMinimalPerf.default	195	186	1.05:1
LoaderMinimalPerf.default	185	177	1.05:1
AttachmentMinimalPerf.default	81	78	1.04:1
ChatWithPopoverPerf.default	200	193	1.04:1
ListMinimalPerf.default	309	296	1.04:1
SkeletonMinimalPerf.default	206	199	1.04:1
TooltipMinimalPerf.default	1309	1260	1.04:1
BoxMinimalPerf.default	198	193	1.03:1
HeaderMinimalPerf.default	194	188	1.03:1
MenuMinimalPerf.default	510	497	1.03:1
SplitButtonMinimalPerf.default	2318	2254	1.03:1
TableMinimalPerf.default	234	228	1.03:1
ButtonSlotsPerf.default	328	322	1.02:1
DividerMinimalPerf.default	206	202	1.02:1
FlexMinimalPerf.default	154	151	1.02:1
RadioGroupMinimalPerf.default	262	256	1.02:1
ToolbarMinimalPerf.default	537	526	1.02:1
TreeWith60ListItems.default	86	84	1.02:1
ChatMinimalPerf.default	446	440	1.01:1
DialogMinimalPerf.default	444	439	1.01:1
DropdownMinimalPerf.default	1435	1423	1.01:1
FormMinimalPerf.default	222	220	1.01:1
ItemLayoutMinimalPerf.default	713	707	1.01:1
PortalMinimalPerf.default	85	84	1.01:1
ProviderMergeThemesPerf.default	669	664	1.01:1
CarouselMinimalPerf.default	257	256	1:1
EmbedMinimalPerf.default	1884	1878	1:1
ListCommonPerf.default	394	394	1:1
ListWith60ListItems.default	366	367	1:1
PopupMinimalPerf.default	342	343	1:1
ReactionMinimalPerf.default	216	217	1:1
CustomToolbarPrototype.default	1487	1491	1:1
ButtonOverridesMissPerf.default	631	636	0.99:1
CheckboxMinimalPerf.default	1129	1139	0.99:1
DatepickerMinimalPerf.default	3517	3549	0.99:1
InputMinimalPerf.default	533	537	0.99:1
MenuButtonMinimalPerf.default	958	965	0.99:1
RosterPerf.default	1515	1532	0.99:1
SliderMinimalPerf.default	727	731	0.99:1
TableManyItemsPerf.default	1096	1110	0.99:1
TreeMinimalPerf.default	474	478	0.99:1
AttachmentSlotsPerf.default	633	643	0.98:1
AvatarMinimalPerf.default	100	102	0.98:1
HeaderSlotsPerf.default	470	480	0.98:1
ImageMinimalPerf.default	231	235	0.98:1
LabelMinimalPerf.default	221	225	0.98:1
ProviderMinimalPerf.default	199	204	0.98:1
TextMinimalPerf.default	189	192	0.98:1
TextAreaMinimalPerf.default	283	288	0.98:1
AnimationMinimalPerf.default	290	300	0.97:1
VideoMinimalPerf.default	429	444	0.97:1
DropdownManyItemsPerf.default	383	402	0.95:1
CardMinimalPerf.default	292	310	0.94:1
StatusMinimalPerf.default	389	412	0.94:1
LayoutMinimalPerf.default	195	210	0.93:1

codesandbox-ci · 2023-08-21T10:24:26Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c9bb37:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-08-21T10:29:54Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2023-08-21T10:30:00Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `330 B`
`global-context` createContextSelector	`537 B` `342 B`
`priority-overflow` createOverflowManager	`4.162 kB` `1.735 kB`
`react-accordion` Accordion (including children components)	`88.592 kB` `26.885 kB`
`react-alert` Alert	`81.836 kB` `22.031 kB`
`react-avatar` Avatar	`47.01 kB` `14.502 kB`
`react-avatar` AvatarGroup	`16.116 kB` `6.431 kB`
`react-avatar` AvatarGroupItem	`61.789 kB` `18.912 kB`
`react-badge` Badge	`23.183 kB` `7.254 kB`
`react-badge` CounterBadge	`24.084 kB` `7.553 kB`
`react-badge` PresenceBadge	`22.14 kB` `7.867 kB`
`react-button` Button	`37.078 kB` `9.751 kB`
`react-button` CompoundButton	`44.427 kB` `11.234 kB`
`react-button` MenuButton	`41.464 kB` `11.001 kB`
`react-button` SplitButton	`49.499 kB` `12.555 kB`
`react-button` ToggleButton	`54.124 kB` `11.65 kB`
`react-card` Card - All	`88.335 kB` `25.271 kB`
`react-card` Card	`83.177 kB` `23.742 kB`
`react-card` CardFooter	`9.338 kB` `3.932 kB`
`react-card` CardHeader	`11.59 kB` `4.716 kB`
`react-card` CardPreview	`10.297 kB` `4.317 kB`
`react-checkbox` Checkbox	`32.872 kB` `10.652 kB`
`react-combobox` Combobox (including child components)	`87.101 kB` `28.273 kB`
`react-combobox` Dropdown (including child components)	`85.461 kB` `27.912 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`66.614 kB` `18.512 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`203.471 kB` `57.83 kB`
`react-components` react-components: FluentProvider & webLightTheme	`37.787 kB` `12.387 kB`
`react-datepicker-compat` DatePicker Compat	`207.157 kB` `57.399 kB`
`react-dialog` Dialog (including children components)	`86.738 kB` `26.341 kB`
`react-divider` Divider	`17.098 kB` `6.303 kB`
`react-field` Field	`18.295 kB` `6.978 kB`
`react-image` Image	`12.029 kB` `4.783 kB`
`react-infobutton` InfoButton	`125.301 kB` `39.269 kB`
`react-infobutton` InfoLabel	`128.971 kB` `40.446 kB`
`react-input` Input	`23.237 kB` `7.688 kB`
`react-label` Label	`10.423 kB` `4.31 kB`
`react-link` Link	`13.254 kB` `5.397 kB`
`react-menu` Menu (including children components)	`135.523 kB` `41.576 kB`
`react-menu` Menu (including selectable components)	`138.209 kB` `42.078 kB`
`react-overflow` hooks only	`12.419 kB` `4.687 kB`
`react-persona` Persona	`53.905 kB` `16.371 kB`
`react-popover` Popover	`114.603 kB` `35.934 kB`
`react-portal` Portal	`12.255 kB` `4.504 kB`
`react-portal-compat` PortalCompatProvider	`6.48 kB` `2.203 kB`
`react-positioning` usePositioning	`25.137 kB` `9.109 kB`
`react-progress` ProgressBar	`13.718 kB` `5.476 kB`
`react-provider` FluentProvider	`18.332 kB` `6.817 kB`
`react-radio` Radio	`26.617 kB` `8.601 kB`
`react-radio` RadioGroup	`11.622 kB` `4.833 kB`
`react-select` Select	`24.599 kB` `8.651 kB`
`react-slider` Slider	`34.134 kB` `11.039 kB`
`react-spinbutton` SpinButton	`32.681 kB` `10.209 kB`
`react-spinner` Spinner	`19.577 kB` `7.008 kB`
`react-switch` Switch	`29.092 kB` `9.217 kB`
`react-table` DataGrid	`152.77 kB` `42.242 kB`
`react-table` Table (Primitives only)	`39.638 kB` `12.129 kB`
`react-table` Table as DataGrid	`126.224 kB` `33.612 kB`
`react-table` Table (Selection only)	`71.594 kB` `18.91 kB`
`react-table` Table (Sort only)	`70.213 kB` `18.511 kB`
`react-tags-preview` InteractionTag	`11.031 kB` `4.528 kB`
`react-tags-preview` Tag	`25.398 kB` `8.396 kB`
`react-tags-preview` TagGroup	`69.607 kB` `20.482 kB`
`react-text` Text - Default	`13.043 kB` `5.129 kB`
`react-text` Text - Wrappers	`16.215 kB` `5.447 kB`
`react-textarea` Textarea	`27.302 kB` `9.047 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.611 kB` `7.295 kB`
`react-theme` Teams: Light theme	`19.282 kB` `5.486 kB`
`react-toast` Toast (including Toaster)	`87.69 kB` `26.037 kB`
`react-tooltip` Tooltip	`47.942 kB` `16.845 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 55e07ffc8d180554fb027841e7d2a89637cefcb3}

size-auditor · 2023-08-21T10:31:46Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 55e07ffc8d180554fb027841e7d2a89637cefcb3 (build)

fabricteam · 2023-08-21T10:34:22Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	600	630	5000
Breadcrumb	mount	1637	1666	1000
Checkbox	mount	1665	1690	5000
CheckboxBase	mount	1466	1475	5000
ChoiceGroup	mount	2927	2967	5000
ComboBox	mount	649	670	1000
CommandBar	mount	6066	6108	1000
ContextualMenu	mount	12545	12390	1000
DefaultButton	mount	733	748	5000
DetailsRow	mount	2120	2193	5000
DetailsRowFast	mount	2173	2161	5000
DetailsRowNoStyles	mount	1999	1985	5000
Dialog	mount	2598	2750	1000
DocumentCardTitle	mount	218	226	1000
Dropdown	mount	1939	1972	5000
FocusTrapZone	mount	1111	1089	5000
FocusZone	mount	1057	1044	5000
GroupedList	mount	40859	41367	2
GroupedList	virtual-rerender	17684	19829	2
GroupedList	virtual-rerender-with-unmount	50625	50494	2
GroupedListV2	mount	214	222	2
GroupedListV2	virtual-rerender	210	201	2
GroupedListV2	virtual-rerender-with-unmount	230	216	2
IconButton	mount	1095	1058	5000
Label	mount	332	333	5000
Layer	mount	2674	2662	5000
Link	mount	383	388	5000
MenuButton	mount	942	936	5000
MessageBar	mount	21206	21212	5000
Nav	mount	1950	1932	1000
OverflowSet	mount	771	761	5000
Panel	mount	1726	1832	1000
Persona	mount	720	733	1000
Pivot	mount	843	839	1000
PrimaryButton	mount	823	831	5000
Rating	mount	4594	4638	5000
SearchBox	mount	896	888	5000
Shimmer	mount	1917	1816	5000
Slider	mount	1326	1325	5000
SpinButton	mount	2853	2847	5000
Spinner	mount	383	386	5000
SplitButton	mount	1846	1844	5000
Stack	mount	403	407	5000
StackWithIntrinsicChildren	mount	839	852	5000
StackWithTextChildren	mount	2543	2547	5000
SwatchColorPicker	mount	6134	6099	5000
TagPicker	mount	1483	1462	5000
Text	mount	361	367	5000
TextField	mount	929	935	5000
ThemeProvider	mount	820	804	5000
ThemeProvider	virtual-rerender	577	583	5000
ThemeProvider	virtual-rerender-with-unmount	1297	1263	5000
Toggle	mount	588	607	5000
buttonNative	mount	198	186	5000

fabricteam · 2023-08-21T11:30:01Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-08-21T11:38:40Z

🕵 fluentuiv9 No visual regressions between this PR and main

YuanboXue-Amber added 2 commits August 21, 2023 12:06

fix

7407158

fix

ee4f945

YuanboXue-Amber requested a review from a team as a code owner August 21, 2023 10:11

comment

1888edc

YuanboXue-Amber mentioned this pull request Aug 21, 2023

[Feature]: Update @swc/helpers to 0.5.x #28919

Closed

1 task

ling1726 reviewed Aug 21, 2023

View reviewed changes

Comment thread .storybook/preview.js Outdated

ling1726 approved these changes Aug 21, 2023

View reviewed changes

YuanboXue-Amber enabled auto-merge (squash) August 21, 2023 10:39

YuanboXue-Amber disabled auto-merge August 21, 2023 10:39

link issue

486cb8b

YuanboXue-Amber enabled auto-merge (squash) August 21, 2023 10:42

YuanboXue-Amber disabled auto-merge August 21, 2023 10:57

Merge branch 'master' into fix-csb

7c9bb37

YuanboXue-Amber enabled auto-merge (squash) August 21, 2023 11:42

YuanboXue-Amber merged commit 7c278ca into microsoft:master Aug 21, 2023

YuanboXue-Amber deleted the fix-csb branch August 21, 2023 12:08

YuanboXue-Amber mentioned this pull request Aug 29, 2023

chore: update swc build dependencies #28989

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: pin @swc/helper in codesandbox as it does not support dependency alias#28918

chore: pin @swc/helper in codesandbox as it does not support dependency alias#28918
YuanboXue-Amber merged 5 commits into
microsoft:masterfrom
YuanboXue-Amber:fix-csb

YuanboXue-Amber commented Aug 21, 2023 •

edited by ling1726

Loading

Uh oh!

fabricteam commented Aug 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Aug 21, 2023 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Aug 21, 2023 •

edited

Loading

Uh oh!

Uh oh!

fabricteam commented Aug 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Aug 21, 2023 •

edited

Loading

Uh oh!

size-auditor Bot commented Aug 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Aug 21, 2023 •

edited

Loading

Uh oh!

fabricteam commented Aug 21, 2023

Uh oh!

fabricteam commented Aug 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

YuanboXue-Amber commented Aug 21, 2023 • edited by ling1726 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

codesandbox-ci Bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fabricteam commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

size-auditor Bot commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Aug 21, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Aug 21, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YuanboXue-Amber commented Aug 21, 2023 •

edited by ling1726

Loading

fabricteam commented Aug 21, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Aug 21, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

codesandbox-ci Bot commented Aug 21, 2023 •

edited

Loading

fabricteam commented Aug 21, 2023 •

edited

Loading

fabricteam commented Aug 21, 2023 •

edited

Loading

size-auditor Bot commented Aug 21, 2023 •

edited

Loading

fabricteam commented Aug 21, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)